Skip to content

Conversation

@famod
Copy link
Member

@famod famod commented Jan 26, 2022

Stumbled upon this while reviewing quarkiverse/quarkus-cxf#347 because Eclipse showed a warning.

Broken since the very beginning, AFAICS: #15380

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 26, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 89b3807

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: core/deployment 
! Skipped: core/test-extension/deployment core/test-extension/runtime devtools/bom-descriptor-json and 619 more

📦 core/deployment

Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.17.1:validate (default) on project quarkus-core-deployment: File '/home/runner/work/quarkus/quarkus/core/deployment/src/main/java/io/quarkus/deployment/builditem/nativeimage/ReflectiveClassBuildItem.java' has not been previously formatted. Please format file and commit before running validation!

@quarkusio quarkusio deleted a comment from quarkus-bot bot Jan 26, 2022
@famod
Copy link
Member Author

famod commented Jan 26, 2022

The fact that this has gone unnoticed for so long makes me wonder whether it's used at all.

@gastaldi
Copy link
Contributor

The fact that this has gone unnoticed for so long makes me wonder whether it's used at all.

+1, perhaps we can remove it but better check with the author first

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@geoand geoand merged commit 5ef428a into quarkusio:main Jan 27, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 27, 2022
@famod famod deleted the ReflectiveClassBuildItem-serialization branch January 27, 2022 07:50
@gsmet
Copy link
Member

gsmet commented Jan 27, 2022

Three of you around and and it didn't even have a backport label?!? :)

@gsmet gsmet modified the milestones: 2.8 - main, 2.7.1.Final Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants