Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass quarkus args to dev mode gradle task #31318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Pass quarkus args to dev mode gradle task #31318

wants to merge 1 commit into from

Conversation

jacobdotcosta
Copy link
Contributor

Tested the fix using the jacobdotcosta/quarkus-issue-28443 project.

Recreates PR #29250
Re-closes #28443

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Feb 21, 2023
@gsmet gsmet requested a review from glefloch February 21, 2023 12:06
@gsmet
Copy link
Member

gsmet commented Feb 21, 2023

/cc @snazy

@quarkus-bot

This comment has been minimized.

Sign in to view
@jacobdotcosta jacobdotcosta mentioned this pull request Feb 27, 2023
Open
@gsmet
Copy link
Member

gsmet commented Mar 1, 2023

@glefloch any chance you could have a look at that one soon?

glefloch
glefloch reviewed Mar 1, 2023
View reviewed changes
Copy link
Member

@glefloch glefloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @gsmet.
Thanks @jacobdotcosta for this work. I just left a small comment.

...radle/src/test/java/io/quarkus/gradle/devmode/BasicJavaMainApplicationModuleDevModeTest.java Outdated
commandOutputLogFile.close();
return false;
} catch (Exception e) {
System.out.println(String.format("e: <message, %s>, <cause, %s>", e.getMessage(), e.getCause()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be replace by proper logging?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobdotcosta any chance you could take care of this request? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Sure thing. Didn't realize you already requested it a couple of weeks ago.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've replaced the System out with logging but...

@gsmet checking the other tests they have no logs. Should I simply remove the log message? I thought it would be interesting to have the error cause but I have no problem with eliminating it so this test is similar to others!

@jacobdotcosta
Copy link
Contributor Author

The errors seem to be :

I'm not sure the latter are related with the OOM.

@jacobdotcosta jacobdotcosta requested a review from glefloch April 11, 2023 08:35
@quarkus-bot

This comment has been minimized.

Sign in to view
@gsmet
Copy link
Member

gsmet commented Jun 7, 2024

I rebased to see if things would be better with all the latest changes.

Our dev mode tests are leaking class loaders so that might just be the addition of a test that causes the issue, let's see how it goes.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 7, 2024
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 17, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e4fc7cd.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✖ Gradle Tests - JDK 17 Build Failures Logs Raw logs 🔍
✔️ Gradle Tests - JDK 17 Windows Logs Raw logs 🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ Gradle Tests - JDK 17 #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.BasicJavaMainApplicationModuleDevModeTest.main - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.gradle.devmode.BasicJavaMainApplicationModuleDevModeTest was not fulfilled within 30 seconds.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at app//io.quarkus.gradle.devmode.BasicJavaMainApplicationModuleDevModeTest.testDevMode(BasicJavaMainApplicationModuleDevModeTest.java:36)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.main(QuarkusDevGradleTestBase.java:60)

@cescoffier
Copy link
Member

@glefloch @gsmet What should we do about this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glefloch glefloch glefloch approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

quarkus.args not work with gradle and quarkus 2.13.0
4 participants
@jacobdotcosta @gsmet @cescoffier @glefloch