figure caption with plotly not showing

[cderv]

---
title: "Test"
format: html
keep-md: true
---

Test to add caption under a plotly graph

```{r}
#| label: fig-plotly
#| fig-cap: "My figure caption here"
#| echo: false
#| message: false

library(plotly)
fig <- plot_ly(midwest, x = ~percollege, color = ~state, type = "box")
fig
```

It seems we are missing some fenced div where the figure caption should have been applied

---
title: "Test"
format: html
keep-md: true
---



Test to add caption under a plotly graph


::: {.cell}


```{=html}
<! --plotly html in here -->
```

:::

I believe this is supposed to work.

I get the same results with v1.2.475 oddly. So not a 1.3 regression, unless one of the patch version introduced this.

Probably something in the knitr hooks. I'll have a look but if anyone has clues, please share

[jjallaire]

It's probably a change in knitr? I think we should look into this for addressing in v1.3 esp. as the problem could go deeper if its in the knir hooks layer.

[cderv]

This is a change in knitr indeed but dev version of knitr that I add installed. We don't test yet against dev version and hopefully I found it now before new release. This is due to yihui/knitr@99cd65a - I'll see if I can adapt here or there.

[jjallaire]

Great, glad we found this now!

[cderv]

I gave details in yihui/knitr#2248

Basically the issue is because we made a change to support collapse = TRUE when HTML widgets in chunks, but this changed what was passed to add_html_caption() and we modify this function within knitr

quarto-cli/src/resources/rmd/patch.R

Lines 111 to 118 in 4977f45

	add_html_caption <- function(options, x) {
	if (inherits(x, 'knit_asis_htmlwidget')) {
	wrap_asis_output(options, x)
	} else {
	x
	}
	}
	assignInNamespace("add_html_caption", add_html_caption, ns = "knitr")

[cderv]

@jjallaire we've pushed a fix in dev knitr to avoid doing the processing.

As @yihui mentions again in the PR review, we may need at some point in the furture to find a way to avoid assignInNamespace().