refactor: simplify lifetimes and closures

crates/cli/src/commands_fix.rs

@@ -21,8 +21,7 @@ pub(crate) fn run_fix(
     if result
         .paths
         .iter()
-        .map(|path| path.files.iter().all(|file| file.violations.is_empty()))
-        .all(|v| v)
+        .all(|path| path.files.iter().all(|file| file.violations.is_empty()))
     {
         let count_files = result
             .paths

crates/lib-core/src/parser/lexer.rs

@@ -461,7 +461,6 @@ impl<'a> Lexer<'a> {
     }
 
     /// Convert a tuple of lexed elements into a tuple of segments.
-
     fn elements_to_segments(
         &self,
         elements: Vec<TemplateElement>,

crates/lib-core/src/parser/segments/base.rs

@@ -383,9 +383,9 @@ impl ErasedSegment {
             .clone()
     }
 
-    pub fn children<'set>(
-        &'set self,
-        seg_types: &'set SyntaxSet,
+    pub fn children(
+        &self,
+        seg_types: &'static SyntaxSet,
     ) -> impl Iterator<Item = &ErasedSegment> + '_ {
         self.segments()
             .iter()

crates/lib-core/src/utils/analysis/query.rs

@@ -46,7 +46,7 @@ pub struct Selectable<'me> {
     pub dialect: &'me Dialect,
 }
 
-impl<'me> Selectable<'me> {
+impl Selectable<'_> {
     pub fn find_alias(&self, table: &str) -> Option<AliasInfo> {
         self.select_info()
             .as_ref()?
@@ -57,7 +57,7 @@ impl<'me> Selectable<'me> {
     }
 }
 
-impl<'me> Selectable<'me> {
+impl Selectable<'_> {
     pub fn wildcard_info(&self) -> Vec<WildcardInfo> {
         let Some(select_info) = self.select_info() else {
             return Vec::new();
@@ -107,7 +107,7 @@ impl<'me> Selectable<'me> {
     }
 }
 
-impl<'me> Selectable<'me> {
+impl Selectable<'_> {
     pub fn select_info(&self) -> Option<SelectStatementColumnsAndTables> {
         if self.selectable.is_type(SyntaxKind::SelectStatement) {
             return get_select_statement_info(&self.selectable, self.dialect.into(), false);

crates/lib/src/core/linter/core.rs

@@ -159,9 +159,7 @@ impl Linter {
 
         expanded_paths
             .par_iter()
-            .filter(|path| {
-                return !ignorer(Path::new(path));
-            })
+            .filter(|path| !ignorer(Path::new(path)))
             .map(|path| {
                 let rendered = self.render_file(path.clone());
                 self.lint_rendered(rendered, fix)

crates/lib/src/core/string_helpers.rs

@@ -1,5 +1,4 @@
 /// String Helpers for the parser module.
-
 /// Yields all the positions sbstr within in_str https://stackoverflow.com/questions/4664850/how-to-find-all-occurrences-of-a-substring
 pub fn find_all(substr: &str, in_str: &str) -> Vec<usize> {
     // Return nothing if one of the inputs is trivial

crates/lib/src/utils/functional/context.rs

@@ -7,7 +7,7 @@ pub struct FunctionalContext<'a> {
 }
 
 impl<'a> FunctionalContext<'a> {
-    pub fn new(context: RuleContext<'a>) -> FunctionalContext {
+    pub fn new(context: RuleContext<'a>) -> Self {
         FunctionalContext { context }
     }