ci: add shellcheck to gha

.github/workflows/pr.yaml

@@ -126,7 +126,6 @@ jobs:
         run: cargo machete
       - name: Cargo hack
         run: cargo hack check --each-feature --exclude-features=codegen-docs
-
   prettier-formatting:
     name: Check Prettier formatting
     runs-on: ubuntu-latest
@@ -143,3 +142,12 @@ jobs:
           cache: "pnpm"
       - run: pnpm install --frozen-lockfile
       - run: pnpm run fmt:check
+  shellcheck:
+    name: Shellcheck
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Run ShellCheck
+        uses: ludeeus/action-shellcheck@master
+        with:
+          scandir: "./.hacking/scripts"

.hacking/scripts/convert_release_to_draft.sh

@@ -1,3 +1,6 @@
+#!/bin/bash
+set -eo pipefail
+
 VERSION="v$(grep "^version" Cargo.toml | awk -F '"' '{print $2}')"
 echo "VERSION: $VERSION"
 

.hacking/scripts/convert_release_to_not_draft.sh

@@ -1,3 +1,6 @@
+#!/bin/bash
+set -eo pipefail
+
 VERSION="v$(grep "^version" Cargo.toml | awk -F '"' '{print $2}')"
 echo "VERSION: $VERSION"
 

.hacking/scripts/update_homebrew_pr.sh

@@ -31,15 +31,14 @@ sed -i "s/version \".*\"/version \"${STRIPPED_VERSION}\"/" sqruff.rb
 # Get the urls and shas for the assets in the release
 
 response=$(curl -s -H "Authorization: Bearer $HOMEBREW_ACCESS_TOKEN" -H "Accept: application/vnd.github.v3+json" "$API_URL")
-echo $response
+echo "$response"
 
 assets=$(echo "$response" | jq -c '.assets[] | {name: .name, url: .url, sha256: .browser_download_url}')
-echo $assets
+echo "$assets"
 
 while read -r asset; do
   echo "Asset: $asset"
   name=$(echo "$asset" | jq -r '.name')
-  url=$(echo "$asset" | jq -r '.url')
   sha256=$(echo "$asset" | jq -r '.sha256')
 
   if [[ "$name" == *"darwin-aarch64"* ]]; then