Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DuckDB LOAD syntax support #891

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Conversation

benfdking
Copy link
Collaborator

@benfdking benfdking commented Oct 21, 2024

Related to #882


For more details, open the Copilot Workspace session.

Copy link

Benchmark for caac59b

Click to view benchmark
Test Base PR %
DepthMap::from_parent 40.3±0.35µs 40.6±0.26µs +0.74%
fix_complex_query 11.9±0.30ms 11.7±0.22ms -1.68%
parse_complex_query 2.9±0.04µs 2.8±0.04µs -3.45%
parse_expression_recursion 5.1±0.02µs 5.0±0.07µs -1.96%
parse_simple_query 821.9±20.28ns 819.0±29.50ns -0.35%

@benfdking benfdking force-pushed the benfdking/fix-duckdb-load-syntax branch from 1684af7 to 7e31a66 Compare November 23, 2024 23:43
Copy link

Benchmark for 5cfd613

Click to view benchmark
Test Base PR %
DepthMap::from_parent 41.5±1.56µs 42.0±0.28µs +1.20%
fix_complex_query 11.9±0.14ms 11.9±0.09ms 0.00%
parse_complex_query 2.9±0.04µs 2.9±0.04µs 0.00%
parse_expression_recursion 5.1±0.03µs 5.1±0.05µs 0.00%
parse_simple_query 818.5±11.23ns 825.5±31.34ns +0.86%

@benfdking benfdking force-pushed the benfdking/fix-duckdb-load-syntax branch from 495c997 to 6f1bd21 Compare November 24, 2024 16:55
@benfdking benfdking force-pushed the benfdking/fix-duckdb-load-syntax branch from 6f1bd21 to 5768e37 Compare November 24, 2024 16:59
@benfdking benfdking marked this pull request as ready for review November 24, 2024 16:59
Copy link

Benchmark for 45cb468

Click to view benchmark
Test Base PR %
DepthMap::from_parent 41.4±0.30µs 41.2±0.26µs -0.48%
fix_complex_query 11.7±0.27ms 11.6±0.16ms -0.85%
parse_complex_query 2.9±0.04µs 2.9±0.05µs 0.00%
parse_expression_recursion 5.1±0.06µs 5.1±0.05µs 0.00%
parse_simple_query 828.3±26.53ns 848.1±27.94ns +2.39%

@benfdking benfdking merged commit a003be0 into main Nov 24, 2024
36 checks passed
@benfdking benfdking deleted the benfdking/fix-duckdb-load-syntax branch November 24, 2024 17:13
Copy link

Benchmark for 1efa34d

Click to view benchmark
Test Base PR %
DepthMap::from_parent 41.6±0.61µs 41.6±0.39µs 0.00%
fix_complex_query 11.5±0.12ms 11.6±0.09ms +0.87%
parse_complex_query 2.9±0.04µs 2.9±0.03µs 0.00%
parse_expression_recursion 5.1±0.07µs 5.1±0.07µs 0.00%
parse_simple_query 829.7±16.55ns 857.0±73.79ns +3.29%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant