New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move cli to return codes always and check #910

Merged

benfdking merged 2 commits into main from refactor_for_status_code

Oct 30, 2024

Collaborator

benfdking commented Oct 30, 2024

No description provided.

benfdking added 2 commits

October 30, 2024 20:51


          refactor: move cli to return codes always

e819930


          internal: adding printing exit codes to ui tests

465f5f5

github-actions bot commented Oct 30, 2024

Benchmark for `a59d038`

Click to view benchmark

Test	Base	PR	%
DepthMap::from_parent	41.3±0.26µs	41.4±1.19µs	+0.24%
fix_complex_query	12.5±0.37ms	12.4±0.33ms	-0.80%
parse_complex_query	2.9±0.02µs	2.9±0.02µs	0.00%
parse_expression_recursion	5.1±0.05µs	5.1±0.04µs	0.00%
parse_simple_query	828.8±14.86ns	856.3±38.21ns	+3.32%

github-actions bot commented Oct 30, 2024

Benchmark for `c44b9ae`

Click to view benchmark

Test	Base	PR	%
DepthMap::from_parent	41.9±2.00µs	42.0±2.38µs	+0.24%
fix_complex_query	12.5±0.57ms	12.2±0.20ms	-2.40%
parse_complex_query	2.9±0.15µs	2.9±0.07µs	0.00%
parse_expression_recursion	5.3±0.06µs	5.2±0.03µs	-1.89%
parse_simple_query	821.6±5.85ns	836.1±34.43ns	+1.76%

benfdking changed the title ~~refactor: move cli to return codes always~~ refactor: move cli to return codes always and check

benfdking merged commit c8d9331 into main

15 checks passed

benfdking deleted the refactor_for_status_code branch

October 30, 2024 20:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet