-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix maturin rust toolchain #920
Conversation
I don't think we need to use nightly. We should either specify version 1.81.0 in rust-toolchain.toml so it installs automatically, or set this version directly in the actions. |
Ahhh yes that makes more sense! I have removed the references in the version in the workflow and updated the I will update the python-ci workflow to run on release instead of PR (which I was doing for testing). |
Thanks for the review @gvozdvmozgu I think it is ready now. I don't think I can merge but once it's in I would really appreciate if you or @benfdking could run a release as I would like to use the .sqruffignore feature that has been added recently. |
Let me have a look at this. This breaks my development flow for some reason can't run |
96c05bd
to
9035035
Compare
Thanks! Nice work. Will do a release as soon as this is in. |
It looks like the python deployments have been failing because the rust-toolchain wasn't set and has been using
stable
by default when I think we want to usenightly
.This PR should fix that. I have tested in a previoud commit by changing the actions trigger to be 'pull request' and it built the artifacts fine for all the jobs: https://github.com/quarylabs/sqruff/actions/runs/11627091156