Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix maturin rust toolchain #920

Merged
merged 6 commits into from
Nov 2, 2024

Conversation

concur1
Copy link
Contributor

@concur1 concur1 commented Nov 1, 2024

It looks like the python deployments have been failing because the rust-toolchain wasn't set and has been using stable by default when I think we want to use nightly.

This PR should fix that. I have tested in a previoud commit by changing the actions trigger to be 'pull request' and it built the artifacts fine for all the jobs: https://github.com/quarylabs/sqruff/actions/runs/11627091156

@concur1 concur1 marked this pull request as draft November 1, 2024 09:34
@gvozdvmozgu
Copy link
Collaborator

I don't think we need to use nightly. We should either specify version 1.81.0 in rust-toolchain.toml so it installs automatically, or set this version directly in the actions.

@concur1
Copy link
Contributor Author

concur1 commented Nov 1, 2024

Ahhh yes that makes more sense!

I have removed the references in the version in the workflow and updated the rust-toolchain.toml file. You can see that the workflow is now passing: https://github.com/quarylabs/sqruff/actions/runs/11627651026?pr=920

I will update the python-ci workflow to run on release instead of PR (which I was doing for testing).

@concur1 concur1 marked this pull request as ready for review November 1, 2024 10:22
@concur1
Copy link
Contributor Author

concur1 commented Nov 1, 2024

Thanks for the review @gvozdvmozgu I think it is ready now. I don't think I can merge but once it's in I would really appreciate if you or @benfdking could run a release as I would like to use the .sqruffignore feature that has been added recently.

@benfdking
Copy link
Collaborator

Let me have a look at this. This breaks my development flow for some reason can't run cargo when I change this.

@benfdking benfdking changed the title Set maturin rust toolchain. ci: fix maturin rust toolchain Nov 2, 2024
@benfdking benfdking added this pull request to the merge queue Nov 2, 2024
@benfdking
Copy link
Collaborator

benfdking commented Nov 2, 2024

Thanks! Nice work. Will do a release as soon as this is in.

Merged via the queue into quarylabs:main with commit 8c5f463 Nov 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants