-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade tantivy to 0.22 #242
Conversation
Using Making use of the new flexibility offered by the |
167e32c
to
da41a7e
Compare
NOTE: This is intentionally still a rough WIP (Sunday night hack time!). I want to get feedback on the macro changes first before putting in more work.
Two changes in tantivy 0.21 -> 0.22 that made the upgrade a little tricky:
tantivy::schema::document::Document
is now a traittantivy::schema::document::Value
is now a traitWe use these a fair bit, especially
Value
. However, I did some research and experimentation and it seems to me that we can useTantivyDocument
(implements the now-traitDocument
) andOwnedValue
(implements the now-traitValue
).The tests are passing. Is this the correct way to go?
If this is the right way to go, I'll proceed to clean up the messy bits in the next couple days and get it merged.