New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove allocation in ord_to_term #1852

Closed

fulmicoton opened this issue Feb 9, 2023 · 0 comments · Fixed by #1928

Assignees

Labels

enhancement help wanted

Collaborator

fulmicoton commented Feb 9, 2023

right ord_to_term creates a sstable reader on the fly, seeks for the data and feeds the found value in a output Vec supplied as argument.

The sstable reader requires its own buffer. This is unnecessary. We find ways to simply use the Vec supplied by the user.

fulmicoton added enhancement help wanted labels

fulmicoton assigned ChillFish8

trinity-1686a assigned trinity-1686a and unassigned ChillFish8

trinity-1686a mentioned this issue

use DeltaReader directly to implement Dictionnary::ord_to_term #1928

Merged

fulmicoton closed this as completed in #1928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment