Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use DeltaReader directly to implement Dictionnary::ord_to_term #1928

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

trinity-1686a
Copy link
Contributor

fix #1852

@trinity-1686a trinity-1686a requested a review from fulmicoton March 6, 2023 09:54
@codecov-commenter
Copy link

Codecov Report

Merging #1928 (194683f) into main (a4f7ca8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1928      +/-   ##
==========================================
- Coverage   94.47%   94.46%   -0.01%     
==========================================
  Files         309      309              
  Lines       56512    56512              
==========================================
- Hits        53387    53386       -1     
- Misses       3125     3126       +1     
Impacted Files Coverage Δ
sstable/src/dictionary.rs 87.74% <100.00%> (ø)
src/schema/schema.rs 98.92% <0.00%> (-0.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fulmicoton fulmicoton merged commit fcf5a25 into main Mar 8, 2023
@fulmicoton fulmicoton deleted the ord-to-term-single-buffer branch March 8, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove allocation in ord_to_term
3 participants