Handle escaped dot in json path in the QueryParser. #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
issue-quickwit/2312-fix-jsonpath-with-dot
branch
from
9a53964 to
7a7d8d5
Compare
fulmicoton
force-pushed
the
issue-quickwit/2312-fix-jsonpath-with-dot
branch
from
7a7d8d5 to
f75bdb1
Compare
Codecov Report
@@ Coverage Diff @@
## main #1682 +/- ##
==========================================
+ Coverage 93.98% 94.04% +0.05%
==========================================
Files 256 256
Lines 48985 49053 +68
==========================================
+ Hits 46040 46132 +92
+ Misses 2945 2921 -24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fmassot
reviewed
Nov 15, 2022
| let mut escaped_state: bool = false; | ||
| let mut json_path_segments = Vec::new(); | ||
| let mut buffer = String::new(); | ||
| for ch in json_path.chars() { |
There was a problem hiding this comment.
nitpick: char or a variable with more than 2 letters
fmassot
reviewed
Nov 15, 2022
| Ok(()) | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_json_field_espace() { |
There was a problem hiding this comment.
Suggested change
| fn test_json_field_espace() { | |
| fn test_json_field_escape() { |
fmassot
approved these changes
Nov 15, 2022
This was referenced Jan 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.