Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add columnar to workspace #1808

Merged
merged 1 commit into from
Jan 20, 2023
Merged

add columnar to workspace #1808

merged 1 commit into from
Jan 20, 2023

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Jan 19, 2023

No description provided.

Copy link
Collaborator

@fulmicoton fulmicoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the unit tests are too slow.... we need the attributes you added in the other PR. please merge this one after.

@codecov-commenter
Copy link

Codecov Report

Merging #1808 (8b780ba) into main (9548570) will decrease coverage by 0.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1808      +/-   ##
==========================================
- Coverage   94.14%   93.61%   -0.54%     
==========================================
  Files         274      314      +40     
  Lines       51992    57135    +5143     
==========================================
+ Hits        48947    53485    +4538     
- Misses       3045     3650     +605     
Impacted Files Coverage Δ
...src/column_index/optional_index/set_block/tests.rs 100.00% <ø> (ø)
src/indexer/segment_updater.rs 94.40% <0.00%> (-1.05%) ⬇️
src/store/index/mod.rs 97.83% <0.00%> (-0.55%) ⬇️
src/query/boolean_query/block_wand.rs 96.85% <0.00%> (-0.21%) ⬇️
columnar/src/column_values/linear.rs 98.72% <0.00%> (ø)
columnar/src/column_index/multivalued_index.rs 92.30% <0.00%> (ø)
columnar/src/tests.rs 100.00% <0.00%> (ø)
...nar/src/column_values/compact_space/blank_range.rs 57.89% <0.00%> (ø)
columnar/src/columnar/writer/mod.rs 81.04% <0.00%> (ø)
columnar/src/column_values/tests.rs 99.24% <0.00%> (ø)
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PSeitz PSeitz merged commit 226d0f8 into main Jan 20, 2023
@PSeitz PSeitz deleted the PSeitz-patch-2 branch January 20, 2023 10:47
Hodkinson pushed a commit to Hodkinson/tantivy that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants