Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the sorting logic that forced column type to be sorted like #1816

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Removed the sorting logic that forced column type to be sorted like #1816

merged 2 commits into from
Jan 20, 2023

Conversation

fulmicoton
Copy link
Collaborator

ColumnTypes.

@fulmicoton fulmicoton force-pushed the columnar-simplification branch from c8a53f6 to 7e836ed Compare January 20, 2023 07:30
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2023 •
edited
Loading

Codecov Report

Merging #1816 (7e836ed) into main (b31fd38) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 7e836ed differs from pull request most recent head e96de2f. Consider uploading reports for the commit e96de2f to get more accurate results

@@            Coverage Diff             @@
##             main    #1816      +/-   ##
==========================================
- Coverage   94.14%   94.13%   -0.01%     
==========================================
  Files         274      274              
  Lines       51992    51992              
==========================================
- Hits        48948    48943       -5     
- Misses       3044     3049       +5
Impacted Files Coverage Δ
src/fastfield/multivalued/mod.rs 97.29% <0.00%> (-1.16%) ⬇️
src/store/index/mod.rs 97.83% <0.00%> (-0.55%) ⬇️
src/query/boolean_query/block_wand.rs 96.85% <0.00%> (-0.21%) ⬇️
fastfield_codecs/src/null_index/sparse.rs 95.27% <0.00%> (-0.19%) ⬇️
src/schema/schema.rs 98.92% <0.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PSeitz PSeitz merged commit 2874554 into main Jan 20, 2023
@PSeitz PSeitz deleted the columnar-simplification branch January 20, 2023 11:43
Hodkinson pushed a commit to Hodkinson/tantivy that referenced this pull request Jan 30, 2023
@fulmicoton @PSeitz
Removed the sorting logic that forced column type to be sorted like (q…
ba05fc7 
…uickwit-oss#1816)

* Removed the sorting logic that forced column type to be sorted like
ColumnTypes.

* add comments

Co-authored-by: PSeitz <PSeitz@users.noreply.github.com>
@PSeitz PSeitz mentioned this pull request Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PSeitz PSeitz PSeitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fulmicoton @codecov-commenter @PSeitz