allow more JSON values, fix i64 special case #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes three things: - Reuse positions_per_path hashmap instead of allocating one per indexed JSON value - Try to cast u64 values to i64 to streamline with search behaviour - Allow top level json values to be of any type, instead of limiting it to JSON objects. Remove special JSON object handling method. TODO: We probably should also try to check f64 to i64 and u64 when indexing, as values may get converted to f64 by the JSON parser
fulmicoton
approved these changes
May 1, 2024
PSeitz
added a commit
to quickwit-oss/quickwit
that referenced
this pull request
May 6, 2024
use JSON for concat fields instead of concatenating text fields. With quickwit-oss/tantivy#2383 we support now non-object values on the root in the JSON field. As a nice side-effect, this will make regular JSON fields more powerful. Instead only for nested types, JSON is now also useable for flat mixed-type fields. Closes: #4924
PSeitz
added a commit
to quickwit-oss/quickwit
that referenced
this pull request
May 6, 2024
use JSON for concat fields instead of concatenating text fields. With quickwit-oss/tantivy#2383 we support now non-object values on the root in the JSON field. As a nice side-effect, this will make regular JSON fields more powerful. Instead only for nested types, JSON is now also useable for flat mixed-type fields. Closes: #4924
PSeitz
added a commit
to quickwit-oss/quickwit
that referenced
this pull request
May 6, 2024
use JSON for concat fields instead of concatenating text fields. With quickwit-oss/tantivy#2383 we support now non-object values on the root in the JSON field. As a nice side-effect, this will make regular JSON fields more powerful. Instead only for nested types, JSON is now also useable for flat mixed-type fields. Closes: #4924
PSeitz
added a commit
to quickwit-oss/quickwit
that referenced
this pull request
May 6, 2024
use JSON for concat fields instead of concatenating text fields. With quickwit-oss/tantivy#2383 we support now non-object values on the root in the JSON field. As a nice side-effect, this will make regular JSON fields more powerful. Instead only for nested types, JSON is now also useable for flat mixed-type fields. Closes: #4924
PSeitz
added a commit
to quickwit-oss/quickwit
that referenced
this pull request
May 13, 2024
use JSON for concat fields instead of concatenating text fields. With quickwit-oss/tantivy#2383 we support now non-object values on the root in the JSON field. As a nice side-effect, this will make regular JSON fields more powerful. Instead only for nested types, JSON is now also useable for flat mixed-type fields. Closes: #4924
PSeitz
added a commit
to quickwit-oss/quickwit
that referenced
this pull request
Jun 8, 2024
use JSON for concat fields instead of concatenating text fields. With quickwit-oss/tantivy#2383 we support now non-object values on the root in the JSON field. As a nice side-effect, this will make regular JSON fields more powerful. Instead only for nested types, JSON is now also useable for flat mixed-type fields. Closes: #4924
philippemnoel
pushed a commit
to paradedb/tantivy
that referenced
this pull request
Aug 31, 2024
This changes three things: - Reuse positions_per_path hashmap instead of allocating one per indexed JSON value - Try to cast u64 values to i64 to streamline with search behaviour - Allow top level json values to be of any type, instead of limiting it to JSON objects. Remove special JSON object handling method. TODO: We probably should also try to check f64 to i64 and u64 when indexing, as values may get converted to f64 by the JSON parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes three things:
indexed JSON value
to JSON objects. Remove special JSON object handling method.
TODO: We probably should also try to check f64 to i64 and u64 when
indexing, as values may get converted to f64 by the JSON parser