Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cardinality aggregation performance #2446

Merged
merged 3 commits into from
Jul 2, 2024

assert for sorted ordinals

4af21bc
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix cardinality aggregation performance #2446

assert for sorted ordinals
4af21bc
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Jul 2, 2024 in 0s

clippy

2 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 2
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check warning on line 195 in src/query/disjunction.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
   --> src/query/disjunction.rs:195:34
    |
195 |                 DoNothingCombiner::default(),
    |                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
    = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

Check warning on line 306 in src/indexer/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless use of `format!`

warning: useless use of `format!`
   --> src/indexer/mod.rs:306:14
    |
306 |             (format!("{field_name_out_internal}"), Type::Str),
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `field_name_out_internal.to_string()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
    = note: `#[warn(clippy::useless_format)]` on by default