Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FASL Libraries #53

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

FASL Libraries #53

wants to merge 14 commits into from

Conversation

kartik-s
Copy link
Contributor

TODO WIP

macrologist
macrologist reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@macrologist macrologist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where'd incbin.h come from? Does it have a license?

Is this ready?

src/asdf-utils.lisp Show resolved Hide resolved
src/bindings.lisp Outdated Show resolved Hide resolved
macrologist
macrologist reviewed Jul 29, 2024
View reviewed changes
src/asdf-utils.lisp Outdated Show resolved Hide resolved
kartik-s
kartik-s commented Aug 12, 2024
View reviewed changes
src/asdf-utils.lisp
"Return a list of all the required systems for SYSTEM topologically
sorted by load order."
(with-recursive-compile-bundle-op
(asdf:required-components system
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: document this

kartik-s
kartik-s commented Aug 12, 2024
View reviewed changes
src/package.lisp
@@ -1,5 +1,7 @@
;;;; package.lisp

(require :sb-sprof)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: depends-on this

eliaslfox
eliaslfox reviewed Aug 12, 2024
View reviewed changes
Copy link

@eliaslfox eliaslfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging this pr should include an end-to-end test involving python to lisp calls and multiple dlls.

src/asdf-utils.lisp
@@ -0,0 +1,82 @@
(in-package #:sbcl-librarian)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible this file should define a custom asdf operation instead of monkey patching an existing one.

@kartik-s kartik-s mentioned this pull request Nov 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macrologist macrologist macrologist left review comments

@eliaslfox eliaslfox eliaslfox left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kartik-s @eliaslfox @macrologist