Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack Removal documentation #4209

Merged
merged 24 commits into from
Nov 21, 2024
Merged

Stack Removal documentation #4209

merged 24 commits into from
Nov 21, 2024

Conversation

drernie
Copy link
Member

@drernie drernie commented Nov 8, 2024

Description

TODO

  • [X ] Documentation
    • [X ] Markdown somewhere in docs/**/*.md that explains the feature to end users (said .md files should be linked from SUMMARY.md so they appear on https://docs.quiltdata.com)

@drernie drernie self-assigned this Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.36%. Comparing base (5945c66) to head (8579000).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4209   +/-   ##
=======================================
  Coverage   39.36%   39.36%           
=======================================
  Files         775      775           
  Lines       35134    35134           
  Branches     5295     5295           
=======================================
  Hits        13829    13829           
  Misses      20108    20108           
  Partials     1197     1197           
Flag Coverage Δ
api-python 91.29% <ø> (ø)
catalog 14.70% <ø> (ø)
lambda 92.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@drernie drernie changed the title Stack Remove documentation Stack Removal documentation Nov 14, 2024
Copy link
Contributor

@kevinemoore kevinemoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very helpful addition to our documentation. I've added a few suggestions for content to add.

Feel free to implement the larger ones in a separate PR. At minimum for this PR, please fix the template/stack mention, and add a quick explanation that this doc is for stacks managed by CloudFormation, and add link to quiltdata/iac to refer terraform users to that repo to find instructions for deleting terraform stacks.

docs/Catalog/RemovingStacks.md Outdated Show resolved Hide resolved
docs/Catalog/RemovingStacks.md Show resolved Hide resolved
docs/Catalog/RemovingStacks.md Show resolved Hide resolved
docs/Catalog/RemovingStacks.md Show resolved Hide resolved
@drernie drernie requested a review from Copilot November 17, 2024 05:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 suggestions.

docs/Catalog/RemovingStacks.md Outdated Show resolved Hide resolved
docs/Catalog/RemovingStacks.md Outdated Show resolved Hide resolved
docs/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
docs/CHANGELOG.md Outdated Show resolved Hide resolved
docs/Catalog/RemovingStacks.md Show resolved Hide resolved
docs/Catalog/RemovingStacks.md Outdated Show resolved Hide resolved
docs/Catalog/RemovingStacks.md Outdated Show resolved Hide resolved
docs/Catalog/RemovingStacks.md Show resolved Hide resolved
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 suggestion.

docs/Catalog/RemovingStacks.md Outdated Show resolved Hide resolved
drernie and others added 3 commits November 19, 2024 18:13
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
docs/Catalog/RemovingStacks.md Outdated Show resolved Hide resolved
docs/Catalog/RemovingStacks.md Outdated Show resolved Hide resolved
docs/Catalog/RemovingStacks.md Outdated Show resolved Hide resolved
docs/Catalog/RemovingStacks.md Outdated Show resolved Hide resolved
docs/Catalog/RemovingStacks.md Outdated Show resolved Hide resolved
@drernie drernie added this pull request to the merge queue Nov 21, 2024
Merged via the queue into master with commit b88874c Nov 21, 2024
38 checks passed
@drernie drernie deleted the deletetion-doc branch November 21, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants