-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack Removal documentation #4209
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4209 +/- ##
=======================================
Coverage 39.36% 39.36%
=======================================
Files 775 775
Lines 35134 35134
Branches 5295 5295
=======================================
Hits 13829 13829
Misses 20108 20108
Partials 1197 1197
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very helpful addition to our documentation. I've added a few suggestions for content to add.
Feel free to implement the larger ones in a separate PR. At minimum for this PR, please fix the template/stack mention, and add a quick explanation that this doc is for stacks managed by CloudFormation, and add link to quiltdata/iac to refer terraform users to that repo to find instructions for deleting terraform stacks.
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 suggestions.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Sergey Fedoseev <fedoseev.sergey@quiltdata.io>
at the very least, this is in the wrong place and may not even be necessary
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 suggestion.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nto deletetion-doc
Description
TODO