Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use code samples #136

Merged
merged 4 commits into from
May 2, 2023
Merged

Update to use code samples #136

merged 4 commits into from
May 2, 2023

Conversation

SteveRosam
Copy link
Collaborator

No description provided.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #38459: Tutorials need updating to refer to Quix Samples rather than Library.

@github-actions
Copy link

github-actions bot commented Apr 26, 2023 •
edited
Loading

Docs preview site available at https://quixdocsdev.blob.core.windows.net/prdev/index.html

tbedford
tbedford suggested changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@tbedford tbedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think because these samples are a Quix-specific thing, and correspond to a UI item, and a repo, we are OK to refer to them as Quix Code Samples, or just Code Samples if the context is clear. At the moment we appear to be using a mix of case. I think word case is appropriate here, so "Code Samples" would be preferred, when referring to the entity contained in the samples repo. WDYT?

I think for the UI nav/menu item itself we should consistently use Code Samples.

@SteveRosam SteveRosam closed this Apr 27, 2023
@SteveRosam SteveRosam reopened this Apr 27, 2023
@SteveRosam SteveRosam closed this Apr 27, 2023
@SteveRosam SteveRosam reopened this Apr 27, 2023
@SteveRosam
Copy link
Collaborator Author

@tbedford updated. Please let me know what you think.

@tbedford tbedford self-requested a review April 27, 2023 09:54
tbedford
tbedford suggested changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@tbedford tbedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

A few minor suggested changes.

@SteveRosam SteveRosam closed this May 2, 2023
@SteveRosam SteveRosam reopened this May 2, 2023
@SteveRosam
Copy link
Collaborator Author

@tbedford how does this look?

tbedford
tbedford approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@tbedford tbedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SteveRosam SteveRosam merged commit d720aa5 into dev May 2, 2023
@SteveRosam SteveRosam deleted the steverosam/sc-38459/tutorials-need-updating-to-refer-to-quix branch May 2, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbedford tbedford tbedford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteveRosam @tbedford