Test: Fix flaky macOS builds by waiting for spawned.on('close')

Ref nodejs/node#45085.
qunitjs · Oct 22, 2022 · 49b20d3 · 49b20d3
1 parent ab8a9b3
commit 49b20d3
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/test/cli/helpers/execute.js b/test/cli/helpers/execute.js
@@ -112,9 +112,11 @@ async function execute (command, options = {}, hook) {
     });
     spawned.on('exit', (exitCode, _signal) => {
       result.code = exitCode;
-      const stderr = normalize(String(result.stderr).trimEnd());
-      if (exitCode !== 0) {
-        reject(new Error('Error code ' + exitCode + '\n' + (stderr || result.stdout)));
+    });
+    // Wait for 'close' event. https://github.com/nodejs/node/issues/45085
+    spawned.on('close', () => {
+      if (result.code !== 0) {
+        reject(new Error('Exit code ' + result.code));
       } else {
         resolve();
       }