Core: Introduce ProcessingQueue in internals #1121
Conversation
trentmwillis
force-pushed
the
processing-queue
branch
from
757b9ad to
ef6f7a8
Compare
src/core/processing-queue.js
Outdated
| generateHash, | ||
| now, | ||
| objectType | ||
| } from "./utilities"; |
There was a problem hiding this comment.
Inconsistent indentation here.
There was a problem hiding this comment.
Good catch! We should probably turn on the eslint rule for indentation...and I should probably update my editor workspace to use tabs in QUnit.
There was a problem hiding this comment.
Re: ESLint rule for indentation: One bit of the jQuery style guide, which the ESLint indent rule doesn't yet support, stymies this.
Specifically: Things that look like a top-level whole-file IIFE or function wrapper, but aren't pure IIFEs, are supposed to have an indent level of zero for contained statements. For example, AMD define callbacks, or assignments to module.exports that are functions, or IIFEs that follow the flexible factory pattern (the factory selector/"intro" code needs one indent level, the actual code needs zero). All of those are use cases not yet supported by ESLint.
That said, we could choose to activate the rule anyway and just accept that for this project, all function bodies will be indented by one tab. I don't think that's the end of the world to be completely honest. And both when we activate the rule and if we consume an upgraded version of the rule which supports our special function indentation preferences, we can use eslint --fix to fix the existing problems fairly easily.
I'll open an issue re: indent rule.
trentmwillis
force-pushed
the
processing-queue
branch
from
ef6f7a8 to
b4d311f
Compare
|
@platinumazure updated, thanks for the review! |
Currently, the logic for processing the queue of tests is scattered. This pulls the two core pieces into a new construct
ProcessingQueuewith an interface that more clearly communicates whatprocessandsynchronizeused to do.In other words:
process()->ProcessingQueue.advance(): Moves the queue forwardsynchronize()->ProcessingQueue.add(): Adds a function to the queueThis is being done preemptively to support the "watch" feature in the forthcoming CLI. We'll need to refactor a portion of how the queue is processed in order to properly abort test runs when watched files change.