Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up condition handlers #160

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Tidy up condition handlers #160

merged 1 commit into from
Jun 20, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented Jun 20, 2024

  • Call the condition cnd
  • Define in "usual" order (message, warning, error)
  • Refactoring warning handler to make logic clearer

@hadley
Tidy up condition handlers
82c8f76 
* Call the condition `cnd`
* Define in "usual" order (message, warning, error)
* Refactoring warning handler to make logic clearer
@hadley hadley requested a review from cderv June 20, 2024 10:31
@hadley
Copy link
Member Author

hadley commented Jun 20, 2024

@cderv no need for detailed review here, but if you have any questions about how the code works this is good time/place to ask so I can make it more clear.

cderv
cderv approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I got it ok. Thanks !

@hadley hadley merged commit ac26733 into main Jun 20, 2024
13 checks passed
@hadley hadley deleted the tidy-handlers branch June 20, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cderv cderv cderv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadley @cderv