Create clearer data structures for keep_message and keep_warning #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the similar change for
stop_on_error
, I think this change makes it easier to reason about what's going on.I think this also better captures my original motivation for adding the
log_warnings
argument; you want some way to say "please capture warnings while continuing to show them in the console.". I'm not sure about the field names here, so please let me know if you have better ideas.