Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create clearer data structures for keep_message and keep_warning #172

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented Jun 22, 2024

Like the similar change for stop_on_error, I think this change makes it easier to reason about what's going on.

I think this also better captures my original motivation for adding the log_warnings argument; you want some way to say "please capture warnings while continuing to show them in the console.". I'm not sure about the field names here, so please let me know if you have better ideas.

@hadley hadley requested a review from cderv June 22, 2024 07:40
Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field names are clear to me. Others that come in mind are on_message$keep and on_message$muffle but that is not better. capture and silence are clear IMO.

The code reads much clearer.

@hadley hadley merged commit 8d2e7ad into main Jun 26, 2024
13 checks passed
@hadley hadley deleted the capture-vs-silence branch June 26, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants