Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FastPFOR in RLE/BP encoder #123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

gaborcsardi
Copy link
Member

@gaborcsardi gaborcsardi commented Feb 15, 2025

The new code is not templated, as we only ever encode uint32_t values currently.
It is much cleaner now, and the encoder itself is probably faster, but this does not really make write_parquet() faster, at least not for flights.

In fact, it is slightly slower for flights x 200, probably because we pack a lot of sections that are shorter than 32 values, so we need to copy them into a buffer first. I guess I can use the old bit packer for these shorter sections.

Bit-packing directly into the output buffer is also problematic because the bit packer is writing out unaligned uint32_t values. It seems to work on aarch64 and x86_64, but it might now work correctly everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant