Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a clickable link to file when already exists and not generated by roxygen2 #1556

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Dec 8, 2023

An alternative would also be to use

"Skipping {.path {path}}"

Using the approach in the cli manual

image

I edited the snapshot test and used transform to strip temp path

@hadley
Copy link
Member

hadley commented Jul 9, 2024

Why remove the snapshot test?

@olivroy
Copy link
Contributor Author

olivroy commented Jul 9, 2024

It had a stochastic output. I could use transform to restore it, but I didn't know about it then!

@hadley
Copy link
Member

hadley commented Jul 9, 2024

Oooh because it's a temp file.

@olivroy
Copy link
Contributor Author

olivroy commented Jul 10, 2024

I restored the snapshot test and fixed a bracket typo! This is ready for your review

@hadley hadley merged commit 10ec8de into r-lib:main Jul 10, 2024
13 checks passed
@hadley
Copy link
Member

hadley commented Jul 10, 2024

Perfect, thank you!

@olivroy olivroy deleted the patch-2 branch July 10, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants