Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX @exportS3method -> @exportS3Method #1590

Merged
merged 2 commits into from
Jul 9, 2024
Merged

FIX @exportS3method -> @exportS3Method #1590

merged 2 commits into from
Jul 9, 2024

Conversation

HenrikBengtsson
Copy link
Contributor

No description provided.

@HenrikBengtsson HenrikBengtsson mentioned this pull request Feb 4, 2024
Closed
@MLopez-Ibanez MLopez-Ibanez mentioned this pull request Mar 6, 2024
Closed
@hadley
Copy link
Member

hadley commented Jul 9, 2024

Can you motivate this change for me? (Apologies if you already have but I've forgotten)

@olivroy
Copy link
Contributor

olivroy commented Jul 9, 2024

@hadley The tag name is @exportS3Method, but some interactive advice mentions the non-existing @exportS3method tag. This PR would fix #1585, #1591

@hadley
Copy link
Member

hadley commented Jul 9, 2024

Ah got it, thanks!

@hadley hadley merged commit f5374ac into r-lib:main Jul 9, 2024
13 checks passed
@MichaelChirico
Copy link
Contributor

+1 just hit this to. I copy-pasted the exportS3method in the error and was all the more confused when the error became "unknown tag".

Maybe it makes sense to add exportS3method as an alias as well? capitalization doesn't seem all that important here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HenrikBengtsson @hadley @olivroy @MichaelChirico