Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean new lints #1149

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Clean new lints #1149

merged 1 commit into from
Sep 11, 2023

Conversation

IndrajeetPatil
Copy link
Collaborator

Found with the devel version of lintr.

Copy link
Collaborator

@lorenzwalthert lorenzwalthert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

@codecov-commenter
Copy link

Codecov Report

Merging #1149 (9314c9c) into main (acd0b46) will not change coverage.
Report is 17 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 9314c9c differs from pull request most recent head 25992d8. Consider uploading reports for the commit 25992d8 to get more accurate results

@@           Coverage Diff           @@
##             main    #1149   +/-   ##
=======================================
  Coverage   92.33%   92.33%           
=======================================
  Files          46       46           
  Lines        2650     2650           
=======================================
  Hits         2447     2447           
  Misses        203      203           
Files Changed Coverage Δ
R/parse.R 87.65% <ø> (ø)
R/rules-line-breaks.R 100.00% <ø> (ø)
R/nest.R 100.00% <100.00%> (ø)
R/rules-indention.R 100.00% <100.00%> (ø)
R/set-assert-args.R 90.47% <100.00%> (ø)
R/testing.R 69.50% <100.00%> (ø)
R/transform-files.R 97.46% <100.00%> (+0.01%) ⬆️
R/ui-caching.R 89.74% <100.00%> (ø)

@IndrajeetPatil IndrajeetPatil merged commit 082603d into main Sep 11, 2023
18 checks passed
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1976817 is merged into main:

  •   :ballot_box_with_check:cache_applying: 259ms -> 257ms [-3.58%, +2.28%]
  •   :ballot_box_with_check:cache_recording: 883ms -> 874ms [-3.35%, +1.36%]
  •   :rocket:without_cache: 1.68s -> 1.63s [-4.54%, -0.51%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@IndrajeetPatil IndrajeetPatil deleted the fix-lints-sep23 branch September 11, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants