Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lintr config and address newly found lints #1158

Merged
merged 4 commits into from
Dec 3, 2023

Conversation

IndrajeetPatil
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (12f7eb6) 92.35% compared to head (a0c7564) 92.31%.
Report is 5 commits behind head on main.

❗ Current head a0c7564 differs from pull request most recent head f8a12b6. Consider uploading reports for the commit f8a12b6 to get more accurate results

Files Patch % Lines
R/io.R 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1158      +/-   ##
==========================================
- Coverage   92.35%   92.31%   -0.04%     
==========================================
  Files          46       46              
  Lines        2654     2655       +1     
==========================================
  Hits         2451     2451              
- Misses        203      204       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 3, 2023

This is how benchmark results would change (along with a 95% confidence interval in relative change) if edf399c is merged into main:

  •   :ballot_box_with_check:cache_applying: 161ms -> 164ms [-1.46%, +4.78%]
  •   :ballot_box_with_check:cache_recording: 541ms -> 538ms [-2.02%, +1.03%]
  •   :ballot_box_with_check:without_cache: 1.03s -> 1.03s [-0.47%, +1.28%]

Further explanation regarding interpretation and methodology can be found in the documentation.

This was referenced Dec 3, 2023
Copy link
Collaborator

@lorenzwalthert lorenzwalthert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

@IndrajeetPatil IndrajeetPatil merged commit 2218546 into main Dec 3, 2023
@IndrajeetPatil IndrajeetPatil deleted the clean-lints-dec23 branch December 3, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants