Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused snapshot #1159

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Delete unused snapshot #1159

merged 2 commits into from
Dec 3, 2023

Conversation

IndrajeetPatil
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil commented Dec 3, 2023

The precommit workflow is going to fail until #1158 is merged, and so need to wait for that PR to be merged.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2218546) 92.31% compared to head (c9b8956) 92.31%.
Report is 3 commits behind head on main.

❗ Current head c9b8956 differs from pull request most recent head 4060db4. Consider uploading reports for the commit 4060db4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1159   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files          46       46           
  Lines        2655     2655           
=======================================
  Hits         2451     2451           
  Misses        204      204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IndrajeetPatil IndrajeetPatil marked this pull request as ready for review December 3, 2023 15:58
Copy link
Collaborator

@lorenzwalthert lorenzwalthert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@IndrajeetPatil IndrajeetPatil merged commit ce89aef into main Dec 3, 2023
14 of 16 checks passed
@IndrajeetPatil IndrajeetPatil deleted the delete-unneeded-snapshot branch December 3, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants