Delete URL check workflow #1160
Conversation
| @@ -161,7 +161,7 @@ A big shout out to anyone who contributed to this release: | |||
| This release was requested by CRAN to resolve an R CMD Check note (#1044). | |||
| A big hand to everyone who made this release possible: | |||
|
|
|||
| [@DaveJarvis](https://github.com/DaveJarvis), | |||
| Dave Jarvis, | |||
There was a problem hiding this comment.
This user no longer exists and so this URL has certainly rotten.
|
The precommit workflow is going to fail until #1158 is merged, and so need to wait for that PR to be merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1160 +/- ##
=======================================
Coverage 92.35% 92.35%
=======================================
Files 46 46
Lines 2654 2654
=======================================
Hits 2451 2451
Misses 203 203 ☔ View full report in Codecov by Sentry. |
|
Ok. So actually I remember now that this issue came up before: https://stackoverflow.com/questions/66738272/how-to-fix-r-cmd-check-note-on-incoming-feasibility-due-to-too-many-requests-f |
|
But I am fine deleting the workflow and do the check upon submission. |
I am not sure what's special about
{styler}that this workflow fails. My hunch is that including a lot of GitHub links corresponding to all contributors somehow makes GitHub API calls exceed beyond the limit for this workflow in this repo.At any rate, this is not so important to merit further investigation. We just need to run URL check before CRAN submission and we should be fine.