Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve a few function names #1249

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Improve a few function names #1249

merged 1 commit into from
Dec 9, 2024

Conversation

IndrajeetPatil
Copy link
Collaborator

We are being unnecessarily terse in some places where we don't need to be. I always feel like I am hitting a little speed bump every time I need to decode these names mentally.

We are being unnecessarily terse in some places where we don't need to be. I always feel like I am hitting a little speed bump every time I need to decode these names mentally.
Copy link
Contributor

github-actions bot commented Dec 9, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 9123afe is merged into main:

  • ✔️cache_applying: 163ms -> 165ms [-2%, +4.43%]
  • ✔️cache_recording: 533ms -> 533ms [-0.93%, +0.65%]
  • ✔️without_cache: 1.01s -> 1.01s [-0.48%, +0.94%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Collaborator

@lorenzwalthert lorenzwalthert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a mental burden for me, but I also wrote it 😄

@IndrajeetPatil IndrajeetPatil merged commit ba3fe63 into main Dec 9, 2024
18 checks passed
@IndrajeetPatil IndrajeetPatil deleted the rename-for-clarity branch December 9, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants