Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused extend_if_comment() #1250

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Remove unused extend_if_comment() #1250

merged 1 commit into from
Dec 11, 2024

Conversation

IndrajeetPatil
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if c320dc4 is merged into main:

  • ✔️cache_applying: 161ms -> 159ms [-4.85%, +2.44%]
  • ✔️cache_recording: 523ms -> 524ms [-1.13%, +1.41%]
  • ✔️without_cache: 1.01s -> 1.02s [-1.08%, +2.02%]

Further explanation regarding interpretation and methodology can be found in the documentation.

lorenzwalthert
lorenzwalthert approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@lorenzwalthert lorenzwalthert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@IndrajeetPatil IndrajeetPatil merged commit 84f250a into main Dec 11, 2024
18 checks passed
@IndrajeetPatil IndrajeetPatil deleted the rm-unused-helpers branch December 11, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzwalthert lorenzwalthert lorenzwalthert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IndrajeetPatil @lorenzwalthert