Remove proxy check in vec_is_list()
#1222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1208
The proxy check was originally suggested here #1003 (comment). I am not convinced that we need it, and it would help with list-rcrds outlined in #1208 to remove it.
I really like how simple
vec_is_list()
is now. It is very easy to explain.Internally, we do not currently use
vec_is_list()
in any way that could cause issues after removing this restriction. We never proxyx
after checking that it is a list withvec_is_list()
. We only use it in:vec_unchop()
to check thatx
is a listvec_unchop()
to check thatindices
is a listlist_sizes()
to check thatx
is a listI think all of these are valid and safe uses of
vec_is_list()