Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSGi import/export headers #247

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

OSGi import/export headers #247

wants to merge 2 commits into from

Conversation

rotty3000
Copy link

@rotty3000 rotty3000 commented Oct 5, 2021 •
edited
Loading

  • <developers><developer><id> element added to silence a complaint from bnd about well formed entries
  • let bnd generate default manifest spec entries, as well as setting all other headers
  • added BND SPI annotations to add the necessary parts to make ServiceLoader work in OSGi (passively)

fixes #242

Signed-off-by: Raymond Augé raymond.auge@liferay.com

Make sure that:

  • [ I would but it's missing ] You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don't submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Issue description

New Public APIs

Additional context

@rotty3000
Copy link
Author

A future step would be to add verification step that assures the metadata does in fact work in an OSGi framework. I can contribute this later.

@rotty3000
OSGi import/export headers
6085f9d 
- <developers><developer><id> element added to silence a complaint from bnd about well formed entries
- let bnd generate default manifest spec entries, as well as setting all other headers
- added BND SPI annotations to add the necessary parts to make ServiceLoader work in OSGi (passively)

fixes r2dbc#242

Signed-off-by: Raymond Augé <raymond.auge@liferay.com>
@rotty3000
verify OSGi metadata using bnd-resolver-maven-plugin
e1e7a98 
Signed-off-by: Raymond Augé <raymond.auge@liferay.com>
@rotty3000
Copy link
Author

This contribution now fully verifies OSGi metadata continuously with the build. If the metadata breaks, the build will fail.

@rotty3000
Copy link
Author

@ascertrobw could you confirm if this works for you?

@mp911de
Copy link
Member

mp911de commented Oct 7, 2021

Thanks a lot. The SPI pom now defines two additional dependencies that will come transitives and we have to use annotations on the service loader component. That is quite a high price for supporting a technology with perceived little demand.

@ascertrobw
Copy link

@ascertrobw could you confirm if this works for you?

Yep, good our side Raymond.

@rotty3000
Copy link
Author

@mp911de it's not the first time I hear this argument. Let me see what I can do to mitigate that cost, give me a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OSGi import/export headers
3 participants
@rotty3000 @mp911de @ascertrobw