This repository was archived by the owner on Nov 17, 2020. It is now read-only.
rabbit_env: Fix parsing of $CONF_ENV_FILE output #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `set` command in the implementation of `/bin/sh` included in the
official RabbitMQ Docker image returns multi-line variable values
differently than the tested Bourne shell implementation (GNU Bash, dash
and FreeBSD sh).
I don't know what implementation is used by that Docker image, but here
is the output of `set`, for a variable set to "\n'test'":
TEST_VAR='
'"'"'test'"'"
The problem was reported in the following discussion:
rabbitmq/rabbitmq-server#2458
While here, add a small testcase to check a couple outputs.
Contributor
|
Since you have Docker up and running, can you see what shell and version is being used for |
Contributor
Author
I just verified and it's dash indeed, from some version of Ubuntu I guess. I never saw that output on the different versions of Debian I tested. |
Contributor
|
Interesting. It must be fixed in the version I'm using. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setcommand in the implementation of/bin/shincluded in the official RabbitMQ Docker image returns multi-line variable values differently than the tested Bourne shell implementation (GNU Bash, dash and FreeBSD sh).I don't know what implementation is used by that Docker image, but here is the output of
set, for a variable set to "\n'test'":The problem was reported in the following discussion:
rabbitmq/rabbitmq-server#2458
While here, add a small testcase to check a couple outputs.