Constants are no longer visible

[danlyons-home]

As part of streamlining the public API surface in #714, the RabbitMQ.Client.Framing.Constants type was made internal. However, it is still referenced in the API documentation for ShutdownEventArgs.ReplyCode.

It should probably be made public again (possibly moving it to a different namespace - e.g., RabbitMQ.Client.Constants) or replaced with something else.

[bording]

As I just commented on #714 (comment), ReplyCode should be an enum instead of needing a separate class to interpret the values.

Of course changing that now would be a breaking change, so I guess in the mean time, opening that class back up is a short-term fix.

[lukebakken]

@danlyons-softek @goldenbull - we'd be happy to review a pull request to implement this suggestion:

so I guess in the mean time, opening that class back up is a short-term fix.

I may or may not have time to get to it soon.