Code cleanups

[stebet]

Proposed Changes

Loads of code cleanups:

• Explicit types instead of var where type is not apparent.
• Removed private setters from properties where they were not used.
• Simplified null-checks to x is null instead of x == null. Also prevents accidental bugs in case == operator would ever be overloaded.
• Made private variables readonly where possible.
• Simplified Properties and Methods to be expression-based where possible.
• Made null-checks implit via property where it made sense to reduce code clutter.
• Changed multiple ifs to switch where possible.

Types of Changes

• Bug fix (non-breaking change which fixes issue #NNNN)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause an observable behavior change in existing systems)
• Documentation improvements (corrections, new content, etc)
• Cosmetic change (whitespace, formatting, etc)

Checklist

• I have read the CONTRIBUTING.md document
• I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
• All tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• Any dependent changes have been merged and published in related repositories

[stebet]

For an example of the most drastic changes and code reductions, see https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/931/files#diff-0ea0e0e737f90115933e0196f709f5b8 for example.

[danielmarbach]

Nit: extra line

[danielmarbach]

Nit: extra line

[danielmarbach]

Do we even need the field here?

[stebet]

Maybe not. I haven't cleaned up fields and made auto properties where possible everywhere yet.

[danielmarbach]

Should we lock the csharp version to not accidentally use something that would not be compatible?

[stebet]

If you use the default csharp version it target the lowest common denominator based on the TargetFrameworks. Bit if needed we can lock it to 7.3 according to this: https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/configure-language-version

[michaelklishin]

It would be very nice to have a version of this for 7.x: this makes the delta with master noticeably wider and complicates backporting of subsequent PRs.