Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to 1.5 #10

Open
jmls opened this issue Nov 16, 2015 · 25 comments
Open

update to 1.5 #10

jmls opened this issue Nov 16, 2015 · 25 comments

Comments

@jmls
Copy link

jmls commented Nov 16, 2015

When starting brackets server, a dialog pops up to say that 1.5 is available, and do I want to install it. I installed brackets server using "npm install brackets -g"

Is it possible to install brackets-server with 1.5 or higher of brackets ?

thanks

@rabchev
Copy link
Owner

rabchev commented Nov 18, 2015

Brackets source code has to be updated to the latest version. That usually is not a trivial task. Brackets-server does quite a few hacks in order to work as a service and when they change something in the core those hack have to be adjusted.

Unfortunately, for the time being I cannot commit to a specific time for updating the source.

@jmls
Copy link
Author

jmls commented Nov 18, 2015

Hi Boyan, thanks for the update. What sort of hacks are required ? I may be able to task one of my team to work on this if you need help

@jmls
Copy link
Author

jmls commented Nov 23, 2015

could you let me know roughly how much time you would expect to convert from 1.4 to 1.5 ? I need to set some budgets to allocate someone to this and I'd rather not guess ;)

@rabchev
Copy link
Owner

rabchev commented Nov 23, 2015

Hi jmls,

The Brackets version in the current brackets-server NPM package is 1.3. I started to update it to 1.4, but I didn't have time to finish it. Meanwhile 1.5 was released.

The update process look like this: start the server, an error pops up, debug, fix it, then the next error pops up and the whole process is repeated until all errors are resolved.

I really don't know how much work is needed, because I don't know how much and what has been changed. Usually, it takes me 15 to 20 hours to resolve all issues.

This week I'm very busy, but I will try to set aside a few hours next week, at least to give you some guidance on the most time consuming issues.

I'll be more than happy if you help with the update.

Thanks for your interest, I'll get back to you as soon as possible. Meanwhile if you have some questions, don't hesitate to ask, I will try to answer more promptly next time. Sorry for the late response.

@rick4470
Copy link

@jmls if you decide to take on the task, I can help out with the update.

@jmls
Copy link
Author

jmls commented Dec 11, 2015

@rick4470 that's awesome ;) Thanks! I'm lining up the ducks, trying to find the space and time for my man to start , anything you can help with would be fantastic

@rabchev
Copy link
Owner

rabchev commented Dec 11, 2015

Guys, I'm struggling to find some time to see what problems have appeared. I'm behind on my work projects. I might be able to spend a few hour this Sunday, though.

@jmls
Copy link
Author

jmls commented Dec 16, 2015

ok, so we've started to play with this. So far we've managed to upgrade to the 1.6 code and all seems to be working well.

however, we are having a problem with extensions. Running on a physical machine, we can install extensions with no problem. however, in a docker container, we get the error "an uknown error has occurred"

Any idea on what may be causing this ?

image

@rabchev
Copy link
Owner

rabchev commented Dec 16, 2015

Can you make pull request with the changes. I will try to reproduce it.

@jmls
Copy link
Author

jmls commented Dec 17, 2015

the only real changes made so far is to replace the code with the 1.6 release ;)

@asthomasdk
Copy link

Has anyone had any luck in upgrading and installing extensions in a Docker container?

As @jmls mentioned, we have been trying to do this upgrade and have run into a basic issue with the installing extensions in a Docker container.

Any clues on what to look for to try and resolve this?

@rabchev any chance you have had time to look at this upgrade ;-)

@rabchev
Copy link
Owner

rabchev commented Jan 5, 2016

I just pushed the new version. There are some problems with some extensions that require Node domains, but the ones that work only in the browser are fine.

I will test more extensively and fix eventual issues in the next a few days.

@asthomasdk It works just fine in docker container, I will prepare a docker file for you.

@asthomasdk
Copy link

Excellent news! We will take a look at what you have done so far and see how this works.

@asthomasdk
Copy link

hi @rabchev - any chance you can share the Dockerfile you are using?

We are very keen to get tty.js and terminal working with brackets-server.

TIA

@rabchev
Copy link
Owner

rabchev commented Jan 7, 2016

I'm still trying to resolve an issue with containers. I will send it to you as soon as I'm ready.

@rabchev
Copy link
Owner

rabchev commented Jan 10, 2016

I've committed the Dockerfile in /docker/dev directory. There is brief explanation in the readme file how to use it.

@dimitrovs
Copy link

+1

@anephew
Copy link

anephew commented May 19, 2017

@jmls , @rabchev Hi! Is there somewhere working server version with 1.9 ?

@asthomasdk
Copy link

We do not yet have a working version with 1.9, only 1.8. But it is high on our wishlist.

Next week, we will be open sourcing a set of projects under the name of "nodeSpeed Development". The main project for this is a project originally built on this brackets-server project. It uses Brackets 1.8 at the moment, runs in Docker (we use Rancher for orchestration but it will also work with docker-compose), uses an implementation of xterm-js as the terminal, user sign-in and authentication (using Auth0) and more.

We are hoping that others will find this useful and that we can work with others on moving this forward as an active set of projects to keep up with Brackets and add new features.

@anephew
Copy link

anephew commented May 19, 2017

@asthomasdk, cool, will wait. But where i can download working version with 1.8?

tnx

@asthomasdk
Copy link

Not sure if anyone else has a working version of this project with 1.8.

@dihuta
Copy link

dihuta commented May 30, 2017

@asthomasdk Was "nodeSpeed Development" released?
Can't wait to see it.

@asthomasdk
Copy link

I see you found the project already ;-) We decided to call the main project nodeSpeed IDE - as our hosted implementation of this will be nodeSpeed Development.

There are still some things to sort out and some more testing to do of this build - but the nodeSpeed IDE project is available for anyone who wants to take a look, try it out - and more importantly start contributing to it.

https://github.com/whoGloo/nodespeed-ide

We are very excited to try and move what was started in this project here forward and hope to get others involved.

@dimitrovs
Copy link

@asthomasdk thanks for your work. I was able to get the docker image working, but I had to switch the user back to root as I want to bind mount my projects. The image size is quite big at 1.6 gigs. I tried building it from alpine but couldn't get all the dependencies to install. Still, quite possibly the best open source hosted IDE out there right now.

@asthomasdk
Copy link

Thanks @dimitrovs!

Good to see you are getting some benefit from this.

We added a non-root user and nvm (for multiple versions of node.js ) to the default build to support a use case with meteor development, which does not like it when you are using root. Until then, we have always had the root user as the only user (as this is fine IMHO for docker based systems like this) and this has worked fine.

Anyway - if you find issues, or have stuff to contribute - feel free to log issues and submit PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants