Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance test Rack::Attack#track #294

Merged
merged 3 commits into from
Mar 13, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions spec/acceptance/track_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
require_relative "../spec_helper"

describe "#track" do
it "notifies when track block returns true" do
Rack::Attack.track("ip 1.2.3.4") do |request|
request.ip == "1.2.3.4"
end

notification_matched = nil
notification_type = nil

ActiveSupport::Notifications.subscribe("rack.attack") do |_name, _start, _finish, _id, request|
notification_matched = request.env["rack.attack.matched"]
notification_type = request.env["rack.attack.match_type"]
end

get "/", {}, "REMOTE_ADDR" => "5.6.7.8"

assert_nil notification_matched
assert_nil notification_type

get "/", {}, "REMOTE_ADDR" => "1.2.3.4"

assert_equal "ip 1.2.3.4", notification_matched
assert_equal :track, notification_type
end
end
53 changes: 53 additions & 0 deletions spec/acceptance/track_throttle_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
require_relative "../spec_helper"
require "timecop"

describe "#track with throttle-ish options" do
it "notifies when throttle goes over the limit without actually throttling requests" do
Rack::Attack.cache.store = ActiveSupport::Cache::MemoryStore.new

Rack::Attack.track("by ip", limit: 1, period: 60) do |request|
request.ip
end

notification_matched = nil
notification_type = nil

ActiveSupport::Notifications.subscribe("rack.attack") do |_name, _start, _finish, _id, request|
notification_matched = request.env["rack.attack.matched"]
notification_type = request.env["rack.attack.match_type"]
end

get "/", {}, "REMOTE_ADDR" => "1.2.3.4"

assert_nil notification_matched
assert_nil notification_type

assert_equal 200, last_response.status

get "/", {}, "REMOTE_ADDR" => "5.6.7.8"

assert_nil notification_matched
assert_nil notification_type

assert_equal 200, last_response.status

get "/", {}, "REMOTE_ADDR" => "1.2.3.4"

assert_equal "by ip", notification_matched
assert_equal :track, notification_type

assert_equal 200, last_response.status

Timecop.travel(60) do
notification_matched = nil
notification_type = nil

get "/", {}, "REMOTE_ADDR" => "1.2.3.4"

assert_nil notification_matched
assert_nil notification_type

assert_equal 200, last_response.status
end
end
end