Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required type in links #413

Closed
m-mohr opened this issue Apr 12, 2023 · 4 comments · Fixed by #416
Closed

Required type in links #413

m-mohr opened this issue Apr 12, 2023 · 4 comments · Fixed by #416

Comments

@m-mohr
Copy link
Collaborator

m-mohr commented Apr 12, 2023

Opening an issue here to keep track of opengeospatial/ogcapi-features#818

It could be that type may actually not be required for all links? It sounds like it only applies to self and alternate. As we made this change recently, I'd like to clarify what OGC APIs actually mean, because it's very inconsistent there. Any maybe, if we understood incorrectly, should revert the change?!

Somewhat related issue: opengeospatial/ogcapi-records#178 (comment)

@m-mohr m-mohr added this to the 1.0.0-rc.4 milestone Apr 12, 2023
@m-mohr
Copy link
Collaborator Author

m-mohr commented Apr 12, 2023

@portele answered in opengeospatial/ogcapi-features#818 (comment) and type is NOT generally required in OAFeat. So I think we should consider reverting the change in RC3, right? @philvarner

@philvarner
Copy link
Collaborator

looks like it.

@m-mohr
Copy link
Collaborator Author

m-mohr commented Apr 12, 2023

By the way, the type requirement change is not in the RC3 changelog, right? We should probably add that to the RC3 changelog as it's quite fundamental change.

@philvarner
Copy link
Collaborator

It does appear to have been left out. I'll make that change and release rc.4 today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants