-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset -> Collection #260
Comments
As said on Gitter, I strongly support to rename dataset to collection as it would be inline with WFS (and openEO). |
In addition, collection is unambiguous and dataset is ambiguous according to the following list of synonyms used by organizations from the CEOS OpenSearch Best Practice Document:
The only unambiguous terms listed here are collection and dataset series, but the latter would imply to use dataset for STAC Items.so I'd still vote for collection. |
So I think overall I like it, since if it all works right then it leads to a really nice integration with WFS3. But I have two fairly major concerns:
I do think 1) can work ok if we call ours STAC Collections, and consistently refer to it as that. And then STAC Collection Properties extension (which I do like), etc. And then I think we should commit to really aligning it with WFS Collections (I know I've pushed that alignment, but I also feel we have not committed - we don't mention it at all in the spec, etc). So that we'd work for STAC Collections to eventually just be an explanation of how to use WFS Collections in a standalone way, or indeed it even can serve as the accessible spec to explain those core fields (and we should work to make it a generic OGC spec that many can use / refer to). So to get towards there I think we'd want to rewrite the Dataset document to reference WFS Collections more, and explain how we are using its core fields and adding a few more to define our collection metadata, etc. Of course that work of rewriting is what I worry about pushing us back more from a release, per concern 2) For my concerns on 2), they can obviously be mitigated some if Matthais and anyone else can really put in a bunch of time this week, to make all the changes needed. So if we really want to go this way then I'm ok with it. But I'd also be happy for us to say let's release 0.6.0 ASAP and make 0.7.0 about renaming this. I see the downside of that, since we want to make that change, so why not just do it. But I'd also like to get us in a habit of more just releasing every month. Part of this is to show momentum to the world, to show that we're working differently and anyone can join in, etc. Curious what @hgs-msmith and @hgs-truthe01 think on this too... |
I agree, that we ned to make sure WFS collections and STAC collections would be described carefully and separately so that it is clear to anybody, but it wasn't a problem until now as there were only few places where WFS collections were mentioned at all. I think if we want to rename it to collections than we should directly do it in 0.6 otherwise it would complicate things and confuse people. We already know this problem from the collections discussions on the last sprint. I can put in a bunch of time to update the spec to collections if we decide for the change, so it would not block a release. We just need a consensus. I agree that we should add some wording regarding the alignment with WFS into the dataset spec and we should make sure that we stay connected and up-to-date with their changes. |
Chris, I agree with the concerns you raise. Furthermore, I've been thinking that it is about time to review overall alignment with WFS 3.0. I propose that we make this a theme for 0.7.0. The dataset/collections concern is clearly in that category. So, in summary I recommend to ship 0.6.0 with dataset and consider this naming issue later. |
I think it will be hard to really discuss alignment with WFS3 until they have their second draft out (other than discussing to skip alignment with WFS3 overall). I think the second draft is expected in July 2019 - not sure why it takes so long. There are several issues that are related to our alignment with Datasets, e.g. opengeospatial/ogcapi-features#171, opengeospatial/ogcapi-features#168 and opengeospatial/ogcapi-features#155 |
#260: Rename 'Dataset extension' to 'Collection extension' + other improvements
Renaming completed |
We've been through this before, but now with the latest suggested changes every
Item
will be required to be part of aDataset
. A root catalog will point to 1 or moreDatasets
.But, in a WFS compliant STAC dynamic API,
Datasets
fall under the /collections endpoint.I think we should just change the name of Datasets to Collections. The extension for shared metadata would be called 'Collection properties'.
And as @m-mohr pointed out on Gitter, there are existing IANA relations named 'collection' and 'items', so we can use those as the rel types in links.
@cholmes
The text was updated successfully, but these errors were encountered: