Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change asset name to title #263

Closed
m-mohr opened this issue Oct 6, 2018 · 3 comments
Closed

Change asset name to title #263

m-mohr opened this issue Oct 6, 2018 · 3 comments
Assignees
@m-mohr
Labels
prio: must-have required for release associated with
Milestone
0.6.0-RC1

Comments

@m-mohr
Copy link
Collaborator

m-mohr commented Oct 6, 2018

As discussed in #262: I would propose to change the asset field name to title. Currently it seems it is usually used for a title and not for an identifier. Name itself is ambigious and it is not really clear whether it should be a identifier or a title.
@cholmes
Copy link
Contributor

cholmes commented Oct 6, 2018

+1

Let's get this change in asap.

@cholmes cholmes added this to the 0.6.0-RC1 milestone Oct 6, 2018
@cholmes cholmes added the prio: must-have required for release associated with label Oct 6, 2018
@m-mohr m-mohr self-assigned this Oct 7, 2018
m-mohr added a commit that referenced this issue Oct 8, 2018
@m-mohr
Changed the asset name to title (fixes #263) and some minor consisten…
1857f2c 
…cy improvements to the documentation.
@m-mohr m-mohr mentioned this issue Oct 8, 2018
Merged
@m-mohr
Copy link
Collaborator Author

m-mohr commented Oct 8, 2018

PR #269 implements this.

m-mohr added a commit that referenced this issue Oct 8, 2018
@m-mohr
Merge pull request #269 from radiantearth/asset_name_to_title
0906728 
#263: Change the asset name to title
@m-mohr
Copy link
Collaborator Author

m-mohr commented Oct 8, 2018

Merged - closing this issue.

@m-mohr m-mohr closed this as completed Oct 8, 2018
@cholmes cholmes mentioned this issue Oct 9, 2018
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-mohr m-mohr

Labels
prio: must-have required for release associated with
Projects
None yet
Milestone
0.6.0-RC1
Development

No branches or pull requests
2 participants
@cholmes @m-mohr