Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] 'set autocommit=0' auto txn begin #298

Closed
BohuTANG opened this issue Apr 10, 2019 · 1 comment
Closed

[feature] 'set autocommit=0' auto txn begin #298

BohuTANG opened this issue Apr 10, 2019 · 1 comment
Assignees
Labels
P0 High priority type: feature
Milestone

Comments

@BohuTANG
Copy link
Contributor

Summary

In TPCC, the client gives:

set autocommit=0

treats as txn begin, it maybe commit/rollback by tpcc.
We should do txn begin when client give the set query set autocommit=0

@BohuTANG BohuTANG added the P0 High priority label Apr 10, 2019
@BohuTANG BohuTANG added this to the v1.0.6 milestone Apr 10, 2019
@BohuTANG BohuTANG self-assigned this Apr 10, 2019
@BohuTANG BohuTANG added P2 Low priority and removed P0 High priority labels Apr 12, 2019
@BohuTANG BohuTANG modified the milestones: v1.0.6, v1.0.7 Apr 16, 2019
@BohuTANG BohuTANG modified the milestones: v1.0.7, v1.0.8 May 17, 2019
@andyli029 andyli029 added P0 High priority type: feature and removed P2 Low priority labels Aug 21, 2019
@andyli029 andyli029 self-assigned this Aug 21, 2019
@andyli029
Copy link
Contributor

andyli029 commented Aug 21, 2019

References:

be related to: proxysql
proxysql does not treat autocommit=0 as a transaction
AUTOCOMMIT=0 Transaction Pattern not working on ProxySQL 1.4

from proxysql:

autocommit=0 doesn't start a transaction, therefore proxysql 
"not treating autocommit=0 as a transaction" is technically correct, 
because there is no transaction yet.
Added new variable mysql-autocommit_false_is_transaction

If mysql-autocommit_false_is_transaction=true (false by default), 
a connection with autocommit=0 is treated as a transaction.

If forward_autocommit=true (false by default), the same behavior applies.

andyli029 pushed a commit to andyli029/radon that referenced this issue Aug 28, 2019
andyli029 added a commit to andyli029/radon that referenced this issue Aug 28, 2019
andyli029 added a commit to andyli029/radon that referenced this issue Aug 28, 2019
andyli029 added a commit to andyli029/radon that referenced this issue Aug 28, 2019
andyli029 added a commit to andyli029/radon that referenced this issue Aug 28, 2019
andyli029 pushed a commit to andyli029/radon that referenced this issue Aug 28, 2019
andyli029 added a commit to andyli029/radon that referenced this issue Aug 28, 2019
andyli029 added a commit to andyli029/radon that referenced this issue Aug 29, 2019
andyli029 added a commit to andyli029/radon that referenced this issue Aug 29, 2019
andyli029 added a commit to andyli029/radon that referenced this issue Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 High priority type: feature
Projects
None yet
Development

No branches or pull requests

2 participants