*: remove all version checks against 23.2

Now that `MinSupported` is `V23_2`, we no longer need to check if 23.2
is active. This change removes all these checks.

Epic: none
Release note: None

Author: RaduBerinde

pkg/ccl/backupccl/restore_planning.go

@@ -1229,11 +1229,6 @@ func restorePlanHook(
 		return nil, nil, nil, false, err
 	}
 
-	if restoreStmt.Options.RemoveRegions && !p.ExecCfg().Settings.Version.IsActive(ctx, clusterversion.V23_2) {
-		return nil, nil, nil, false,
-			errors.Newf("to set the remove_regions option, cluster version must be >= %s", clusterversion.V23_2.String())
-	}
-
 	if !restoreStmt.Options.SchemaOnly && restoreStmt.Options.VerifyData {
 		return nil, nil, nil, false,
 			errors.New("to set the verify_backup_table_data option, the schema_only option must be set")

pkg/clusterversion/README.md

@@ -147,13 +147,19 @@ avoid large changes on `master` which might cause merge conflicts for backports.
 
 - [ ] File issue(s) to remove `TODO_Delete_` uses and simplify related code; assign
   to relevant teams (depending on which top-level packages use such gates).
+  Version checks against what is now the minimum version (e.g. `V23_2`) should
+  also be removed, as this version will always be active.
   <details><summary>For the overachiever</summary>
   Historically, these cleanup issues have not received much attention and the code
   was carried over for a long time. Feel free to ping individuals or do some of
-  the cleanup directly (in separate PRs). The cleanup comes down to simplifying the
-  code based on the knowledge that `IsActive()` will always return `true` for
-  obsolete gates. If simplifying the code becomes non-trivial, error on the side
-  of just removing `IsActive()` calls and leaving TODOs for further cleanup.
+  the cleanup directly (in separate PRs).
+  
+  The cleanup comes down to simplifying the code based on the knowledge that
+  `IsActive()` will always return `true` for obsolete gates. If simplifying the
+  code becomes non-trivial, error on the side of just removing `IsActive()` calls
+  and leaving TODOs for further cleanup.
+  
+  Example PRs: #124013, #124286
   </details>
 
 - [ ] Regenerate expected test data results as needed; file issues for any

pkg/kv/kvclient/kvcoord/dist_sender_mux_rangefeed.go

@@ -17,7 +17,6 @@ import (
 	"sync/atomic"
 	"unsafe"
 
-	"github.com/cockroachdb/cockroach/pkg/clusterversion"
 	"github.com/cockroachdb/cockroach/pkg/kv/kvclient/rangecache"
 	"github.com/cockroachdb/cockroach/pkg/kv/kvpb"
 	"github.com/cockroachdb/cockroach/pkg/roachpb"
@@ -645,9 +644,6 @@ func (c *muxStream) close() (toRestart []*activeMuxRangeFeed) {
 func NewCloseStreamRequest(
 	ctx context.Context, st *cluster.Settings, streamID int64,
 ) (*kvpb.RangeFeedRequest, error) {
-	if !st.Version.IsActive(ctx, clusterversion.V23_2) {
-		return nil, errors.Newf("CloseStream request requires cluster version 23.2 or above, found %s", st.Version)
-	}
 	return &kvpb.RangeFeedRequest{
 		StreamID:    streamID,
 		CloseStream: true,

pkg/kv/kvserver/batcheval/cmd_delete_range.go

@@ -14,31 +14,20 @@ import (
 	"context"
 	"time"
 
-	"github.com/cockroachdb/cockroach/pkg/clusterversion"
 	"github.com/cockroachdb/cockroach/pkg/keys"
 	"github.com/cockroachdb/cockroach/pkg/kv/kvpb"
 	"github.com/cockroachdb/cockroach/pkg/kv/kvserver/batcheval/result"
 	"github.com/cockroachdb/cockroach/pkg/kv/kvserver/kvserverpb"
 	"github.com/cockroachdb/cockroach/pkg/kv/kvserver/lockspanset"
 	"github.com/cockroachdb/cockroach/pkg/kv/kvserver/spanset"
 	"github.com/cockroachdb/cockroach/pkg/roachpb"
-	"github.com/cockroachdb/cockroach/pkg/settings"
 	"github.com/cockroachdb/cockroach/pkg/storage"
 	"github.com/cockroachdb/cockroach/pkg/storage/enginepb"
 	"github.com/cockroachdb/cockroach/pkg/storage/fs"
 	"github.com/cockroachdb/cockroach/pkg/util/hlc"
 	"github.com/cockroachdb/errors"
 )
 
-// enableStickyGCHint controls whether the sticky GCHint is enabled.
-var enableStickyGCHint = settings.RegisterBoolSetting(
-	settings.SystemOnly,
-	"kv.gc.sticky_hint.enabled",
-	"enable writing sticky GC hints which expedite garbage collection after schema changes"+
-		" (ignored and assumed 'true' in 23.2)",
-	false,
-)
-
 func init() {
 	RegisterReadWriteCommand(kvpb.DeleteRange, declareKeysDeleteRange, DeleteRange)
 }
@@ -152,14 +141,7 @@ func DeleteRange(
 				return err
 			}
 
-			updated := false
-			// TODO(pavelkalinnikov): deprecate the cluster setting and call
-			// ScheduleGCFor unconditionally when min supported version is 23.2.
-			if cArgs.EvalCtx.ClusterSettings().Version.IsActive(ctx, clusterversion.V23_2) ||
-				enableStickyGCHint.Get(&cArgs.EvalCtx.ClusterSettings().SV) {
-				// Add the timestamp to GCHint to guarantee that GC eventually clears it.
-				updated = hint.ScheduleGCFor(h.Timestamp)
-			}
+			updated := hint.ScheduleGCFor(h.Timestamp)
 			// If the range tombstone covers the whole Range key span, update the
 			// corresponding timestamp in GCHint to enable ClearRange optimization.
 			if args.Key.Equal(desc.StartKey.AsRawKey()) && args.EndKey.Equal(desc.EndKey.AsRawKey()) {

pkg/kv/kvserver/replica_raft.go

@@ -17,7 +17,6 @@ import (
 	"strings"
 	"time"
 
-	"github.com/cockroachdb/cockroach/pkg/clusterversion"
 	"github.com/cockroachdb/cockroach/pkg/keys"
 	"github.com/cockroachdb/cockroach/pkg/kv/kvpb"
 	"github.com/cockroachdb/cockroach/pkg/kv/kvserver/apply"
@@ -2728,14 +2727,7 @@ func shouldCampaignAfterConfChange(
 			return false
 		}
 	}
-	// Prior to 23.2, the first voter in the descriptor campaigned, so we do
-	// the same in mixed-version clusters to avoid ties.
-	if !st.Version.IsActive(ctx, clusterversion.V23_2) {
-		if storeID != desc.Replicas().VoterDescriptors()[0].StoreID {
-			// We're not the designated campaigner.
-			return false
-		}
-	} else if !leaseStatus.OwnedBy(storeID) || !leaseStatus.IsValid() {
+	if !leaseStatus.OwnedBy(storeID) || !leaseStatus.IsValid() {
 		// We're not the leaseholder.
 		return false
 	}

pkg/kv/kvserver/store.go

@@ -378,19 +378,11 @@ func newRaftConfig(
 		Storage:                     strg,
 		Logger:                      logger,
 
-		// StepDownOnRemoval requires 23.2. Otherwise, in a mixed-version cluster, a
-		// 23.2 leader may step down when it demotes itself to learner, but a
-		// designated follower (first in the range) running 23.1 will only campaign
-		// once the leader is entirely removed from the range descriptor (see
-		// shouldCampaignOnConfChange). This would leave the range without a leader,
-		// having to wait out an election timeout.
-		//
 		// We only set this on replica initialization, so replicas without
 		// StepDownOnRemoval may remain on 23.2 nodes until they restart. That's
 		// totally fine, we just can't rely on this behavior until 24.1, but
 		// we currently don't either.
-		StepDownOnRemoval: storeCfg.Settings.Version.IsActive(ctx, clusterversion.V23_2) &&
-			raftStepDownOnRemoval,
+		StepDownOnRemoval: raftStepDownOnRemoval,
 
 		PreVote:     true,
 		CheckQuorum: storeCfg.RaftEnableCheckQuorum,

pkg/server/job_profiler.go

@@ -15,7 +15,6 @@ import (
 	"fmt"
 	"strconv"
 
-	"github.com/cockroachdb/cockroach/pkg/clusterversion"
 	"github.com/cockroachdb/cockroach/pkg/jobs"
 	"github.com/cockroachdb/cockroach/pkg/jobs/jobspb"
 	"github.com/cockroachdb/cockroach/pkg/kv"
@@ -29,7 +28,6 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/util/log"
 	"github.com/cockroachdb/cockroach/pkg/util/timeutil"
 	"github.com/cockroachdb/cockroach/pkg/util/tracing/zipper"
-	"github.com/cockroachdb/errors"
 	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/status"
 )
@@ -67,10 +65,6 @@ func (s *statusServer) RequestJobProfilerExecutionDetails(
 	// profiler details.
 	if local {
 		jobID := jobspb.JobID(req.JobId)
-		if !execCfg.Settings.Version.IsActive(ctx, clusterversion.V23_2) {
-			return nil, errors.Newf("execution details can only be requested on a cluster with version >= %s",
-				clusterversion.V23_2.String())
-		}
 		e := makeJobProfilerExecutionDetailsBuilder(execCfg.SQLStatusServer, execCfg.InternalDB, jobID, execCfg.JobRegistry)
 
 		// TODO(adityamaru): When we start collecting more information we can consider

pkg/server/node.go

@@ -2047,9 +2047,6 @@ func (n *Node) MuxRangeFeed(stream kvpb.Internal_MuxRangeFeedServer) error {
 
 			if err == nil {
 				cause := kvpb.RangeFeedRetryError_REASON_RANGEFEED_CLOSED
-				if !n.storeCfg.Settings.Version.IsActive(ctx, clusterversion.V23_2) {
-					cause = kvpb.RangeFeedRetryError_REASON_REPLICA_REMOVED
-				}
 				err = kvpb.NewRangeFeedRetryError(cause)
 			}
 

pkg/settings/registry.go

@@ -243,6 +243,7 @@ var retiredSettings = map[InternalKey]struct{}{
 
 	// removed as of 24.2
 	"storage.value_blocks.enabled": {},
+	"kv.gc.sticky_hint.enabled":    {},
 }
 
 // sqlDefaultSettings is the list of "grandfathered" existing sql.defaults

pkg/sql/alter_index_visible.go

@@ -13,15 +13,13 @@ package sql
 import (
 	"context"
 
-	"github.com/cockroachdb/cockroach/pkg/clusterversion"
 	"github.com/cockroachdb/cockroach/pkg/sql/catalog"
 	"github.com/cockroachdb/cockroach/pkg/sql/catalog/descpb"
 	"github.com/cockroachdb/cockroach/pkg/sql/catalog/tabledesc"
 	"github.com/cockroachdb/cockroach/pkg/sql/pgwire/pgcode"
 	"github.com/cockroachdb/cockroach/pkg/sql/pgwire/pgerror"
 	"github.com/cockroachdb/cockroach/pkg/sql/privilege"
 	"github.com/cockroachdb/cockroach/pkg/sql/sem/tree"
-	"github.com/cockroachdb/cockroach/pkg/util/errorutil/unimplemented"
 	"github.com/cockroachdb/cockroach/pkg/util/log/eventpb"
 )
 
@@ -86,12 +84,6 @@ func (n *alterIndexVisibleNode) startExec(params runParams) error {
 		return pgerror.Newf(pgcode.FeatureNotSupported, "primary index cannot be invisible")
 	}
 
-	activeVersion := params.ExecCfg().Settings.Version.ActiveVersion(params.ctx)
-	if !activeVersion.IsActive(clusterversion.V23_2) &&
-		n.n.Invisibility.Value > 0.0 && n.n.Invisibility.Value < 1.0 {
-		return unimplemented.New("partially visible indexes", "partially visible indexes are not yet supported")
-	}
-
 	// Warn if this invisible index may still be used to enforce constraint check
 	// behind the scene.
 	if n.n.Invisibility.Value != 0.0 {