Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secure build pipeline #184

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

dsm0014
Copy link
Collaborator

@dsm0014 dsm0014 commented Jul 12, 2024

No description provided.

Copy link

sonarcloud bot commented Jul 13, 2024

password: ${{ secrets.DOCKERHUB_TOKEN }}

- name: Build and push snapshot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use case for publishing snapshots? For dev/testing, I'd expect devs to build locally. I'm definitely open to the idea, but I'd like to document the use case.

tags: rafttech/konfirm:${{ env.RELEASE_VERSION }}

- name: Generate Snapshot SBOM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above regarding snapshots.

image-ref: rafttech/konfirm:${{ github.sha }}

- name: Generate Release SBOM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SBOMs are also available via GitHub, which uses go.mod/go.sum. That wouldn't include the base image, but I wonder if that wouldn't be more accurate for Go dependencies. Can the two be merged in some way, or can Trivy include the image scan and go.mod/sum?

image-ref: rafttech/konfirm:${{ env.RELEASE_VERSION }}

- name: Upload SBOM to pipeline
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we upload the generated SBOM to Docker Hub? If so, can we add an attestation/signature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants