-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
secure build pipeline #184
base: develop
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
password: ${{ secrets.DOCKERHUB_TOKEN }} | ||
|
||
- name: Build and push snapshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the use case for publishing snapshots? For dev/testing, I'd expect devs to build locally. I'm definitely open to the idea, but I'd like to document the use case.
tags: rafttech/konfirm:${{ env.RELEASE_VERSION }} | ||
|
||
- name: Generate Snapshot SBOM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above regarding snapshots.
image-ref: rafttech/konfirm:${{ github.sha }} | ||
|
||
- name: Generate Release SBOM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SBOMs are also available via GitHub, which uses go.mod/go.sum. That wouldn't include the base image, but I wonder if that wouldn't be more accurate for Go dependencies. Can the two be merged in some way, or can Trivy include the image scan and go.mod/sum?
image-ref: rafttech/konfirm:${{ env.RELEASE_VERSION }} | ||
|
||
- name: Upload SBOM to pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we upload the generated SBOM to Docker Hub? If so, can we add an attestation/signature?
No description provided.