Preload all by default #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierjulio
added a commit
to activeadmin/activeadmin
that referenced
this pull request
Jan 2, 2024
javierjulio
added a commit
to activeadmin/activeadmin
that referenced
this pull request
Jan 2, 2024
* Preload all pins rails/importmap-rails#218 * Disable shim for importmaps Prep for importmap-rails v2 by using the new defaults now, even on v1. rails/importmap-rails#216
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An app has to be very large to benefit from partial/on-demand loading. And that's the only time where you wouldn't want to preload your dependencies, because the cost of water falling would be less than the cost of loading it all. For most applications, you'd rather have zero waterfall by default, and load all your JavaScript up front. So that should be the default.