From b7155104e7cca18af38b85af24e1529908230c26 Mon Sep 17 00:00:00 2001
From: maisumakun <maisumakun@users.noreply.github.com>
Date: Fri, 12 Feb 2016 09:23:39 +0900
Subject: [PATCH 1/2] applying required handling in select element too

---
 src/rails.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/rails.js b/src/rails.js
index 012d5092..dd45029c 100644
--- a/src/rails.js
+++ b/src/rails.js
@@ -45,7 +45,7 @@
     enableSelector: 'input[data-disable-with]:disabled, button[data-disable-with]:disabled, textarea[data-disable-with]:disabled, input[data-disable]:disabled, button[data-disable]:disabled, textarea[data-disable]:disabled',
 
     // Form required input elements
-    requiredInputSelector: 'input[name][required]:not([disabled]), textarea[name][required]:not([disabled])',
+    requiredInputSelector: 'input[name][required]:not([disabled]), textarea[name][required]:not([disabled]), select[name][required]:not([disabled])',
 
     // Form file input elements
     fileInputSelector: 'input[type=file]:not([disabled])',

From 8d4307048a36cfbb7385eb7cea376b2642743600 Mon Sep 17 00:00:00 2001
From: Takaaki Kinoshita <t.kinoshita@jeb.bz>
Date: Fri, 12 Feb 2016 09:38:24 +0900
Subject: [PATCH 2/2] Add test for required select

---
 test/public/test/call-remote-callbacks.js | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/test/public/test/call-remote-callbacks.js b/test/public/test/call-remote-callbacks.js
index beee0a0c..6ae93215 100644
--- a/test/public/test/call-remote-callbacks.js
+++ b/test/public/test/call-remote-callbacks.js
@@ -110,7 +110,7 @@ asyncTest('stopping the "ajax:beforeSend" event aborts the request', 1, function
   });
 });
 
-asyncTest('blank required form input field should abort request and trigger "ajax:aborted:required" event', 5, function() {
+asyncTest('blank required form input field should abort request and trigger "ajax:aborted:required" event', 6, function() {
   $(document).bind('iframe:loading', function() {
     ok(false, 'form should not get submitted');
   });
@@ -118,19 +118,21 @@ asyncTest('blank required form input field should abort request and trigger "aja
   var form = $('form[data-remote]')
     .append($('<input type="text" name="user_name" required="required">'))
     .append($('<textarea name="user_bio" required="required"></textarea>'))
+    .append($('<select name="dropdown_test" required="required"><option value="">-</option><option value="Tyler">Tyler</option></textarea>'))
     .bind('ajax:beforeSend', function() {
       ok(false, 'ajax:beforeSend should not run');
     })
     .bind('ajax:aborted:required', function(e,data){
-      ok(data.length == 2, 'ajax:aborted:required event is passed all blank required inputs (jQuery objects)');
+      ok(data.length == 3, 'ajax:aborted:required event is passed all blank required inputs (jQuery objects)');
       ok(data.first().is('input[name="user_name"]') , 'ajax:aborted:required adds blank required input to data');
-      ok(data.last().is('textarea[name="user_bio"]'), 'ajax:aborted:required adds blank required textarea to data');
+      ok(data.eq(1).is('textarea[name="user_bio"]'), 'ajax:aborted:required adds blank required textarea to data');
+      ok(data.last().is('select[name="dropdown_test"]'), 'ajax:aborted:required adds blank required textarea to data');
       ok(true, 'ajax:aborted:required should run');
     })
     .trigger('submit');
 
   setTimeout(function() {
-    form.find('input[required],textarea[required]').val('Tyler');
+    form.find('input[required],textarea[required],select[required]').val('Tyler');
     form.unbind('ajax:beforeSend');
     submit();
   }, 13);
@@ -170,6 +172,7 @@ asyncTest('disabled fields should not be included in blank required check', 2, f
   var form = $('form[data-remote]')
     .append($('<input type="text" name="user_name" required="required" disabled="disabled">'))
     .append($('<textarea name="user_bio" required="required" disabled="disabled"></textarea>'))
+    .append($('<select name="dropdown_test" required="required" disabled="disabled"><option value="">-</option><option value="Tyler">Tyler</option></textarea>'))
     .bind('ajax:beforeSend', function() {
       ok(true, 'ajax:beforeSend should run');
     })