From 9357aa583b450a31b9811aa60c56ebb63161993c Mon Sep 17 00:00:00 2001 From: Koichi ITO Date: Tue, 9 Jul 2024 23:13:25 +0900 Subject: [PATCH] Drop rubocop-minitest from gem dependency Closes #13. This PR drops rubocop-minitest from gem dependency. In fact, the `Minitest` department's Cop is not used in rubocop-rails-omakase: https://github.com/rails/rubocop-rails-omakase/blob/v1.0.0/rubocop.yml This means that it might be appropriate for users to add the `Minitest` department's cop only when they start using it. As a result, there will be no need to install gems that are not included in the rubocop-rails-omakase configuration. Users can be given the choice to add cops based on the testing framework they are using. --- rubocop-rails-omakase.gemspec | 1 - rubocop.yml | 1 - 2 files changed, 2 deletions(-) diff --git a/rubocop-rails-omakase.gemspec b/rubocop-rails-omakase.gemspec index 5deea47..c962103 100644 --- a/rubocop-rails-omakase.gemspec +++ b/rubocop-rails-omakase.gemspec @@ -13,7 +13,6 @@ Gem::Specification.new do |s| s.add_dependency "rubocop" s.add_dependency "rubocop-rails" s.add_dependency "rubocop-performance" - s.add_dependency "rubocop-minitest" s.files = %w[ rubocop.yml ] end diff --git a/rubocop.yml b/rubocop.yml index 4029ab1..4437ef7 100644 --- a/rubocop.yml +++ b/rubocop.yml @@ -1,7 +1,6 @@ require: - rubocop-performance - rubocop-rails - - rubocop-minitest inherit_mode: merge: