Skip to content

Migrate CI from Travis CI to GitHub Actions #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2022

Conversation

mishina2228
Copy link

@mishina2228 mishina2228 commented May 26, 2022

Since June 15th, 2021, the building on travis-ci.org is ceased.
This PR migrates CI from Travis CI to GitHub Actions.
Here are the details:

  • Run CI on Ruby 2.7, 3.0, 3.1 and head
  • Update dependencies
    • Add rack-session to Gemfile
      • rack-session is removed from rack runtime dependency.
      • Without rack-session, the following error occurs:
      /home/runner/work/web-console/web-console/vendor/bundle/ruby/2.7.0/gems/zeitwerk-2.5.4/lib/zeitwerk/kernel.rb:35:in `require': cannot load such file -- rack/session/abstract/id (LoadError)
      
    • Remove arel from Gemfile
      • Arel is now bundled in the Active Record gem, and maintained in the rails/rails repository.
  • bundle exec rake templates:test fails so far, but this PR does not address it.
    I'm investigating and trying to resolve it.
    EDIT: I've fixed it in Fix rake templates:test #318.

EDIT: CI status can be seen here: https://github.com/mishina2228/web-console/actions/runs/2385207305
image

@gsamokovarov
Copy link
Collaborator

Yes! Let's test this setup and replace Travis.

@mishina2228
Copy link
Author

mishina2228 commented Jun 9, 2022

bundle exec rake templates:test fails so far, but this PR does not address it.
I'm investigating and trying to resolve it.

Finally, I succeeded in fixing bundle exec rake templates:test.
I created #318 as another PR, please take a look.

- Rails 7 requires Ruby 2.7+
- Add rack-session to Gemfile
  - rack-session is removed from rack runtime dependency.
- Remove arel from Gemfile
  - Arel is now bundled in the Active Record gem, and maintained in the rails/rails repository.
@mishina2228 mishina2228 changed the title Add GitHub Actions workflow Migrate CI from Travis CI to GitHub Actions Jun 12, 2022
@mishina2228
Copy link
Author

I rebased the branch and replaced Travis with GitHub Actions.

@gsamokovarov gsamokovarov merged commit 0388eef into rails:master Jun 12, 2022
@gsamokovarov
Copy link
Collaborator

I have merged #318. Thanks for you great work on getting us to GitHub Actions! 🎉

@mishina2228 mishina2228 deleted the github-actions branch June 12, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants