Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only include dev-server parts if for dev server #2644

Merged
merged 3 commits into from
Jul 9, 2020
Merged

Only include dev-server parts if for dev server #2644

merged 3 commits into from
Jul 9, 2020

Commits on Jun 25, 2020

  1. Only include dev-server parts if for dev server 

    Without this change, webpack still includes things like window
in the build even if not using the webpack-dev-server.

When that happens, the bundle cannot be used for server-side rendering.
    @justin808
    justin808 committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    0080a64 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. Linting

    @justin808
    justin808 committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    aaca715 View commit details
    Browse the repository at this point in the history

  2. Add jest test

    @justin808
    justin808 committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    2882712 View commit details
    Browse the repository at this point in the history